search

osm-fr / osmose-backend

Part of osmose that runs the analysis, and send the results to the frontend.
GNU General Public License v3.0
90 stars 115 forks source link

Check for wikidata syntax #2175

Open ivanbranco opened 6 months ago

ivanbranco commented 6 months ago

Could a check for wikidata tags (wikidata, operator:wikidata, brand:wikidata, artist:wikidata ecc.) be run? The syntax require the value to be a valid wikidata item, so:

  1. it must start with Q
  2. it must be followed by numbers only

examples of elements that should be flagged:

  1. https://www.openstreetmap.org/node/11090384359/ here species:wikidata equals "Q156895natural=tree". There are letters after the first Q, so it should be flagged and fixed.
  2. https://www.openstreetmap.org/relation/16694980 here the name:etymology:wikidata should be fixed and the value eventually moved to name:etymology:wikipedia
  3. https://www.openstreetmap.org/way/856347720 operator:wikidata value is not a wikidata item
  4. ecc.ecc.
Famlam commented 6 months ago

The first one is already detected: link

Maybe they would be interested to include the other types too (and synchronize this with Osmose)? Its maintained via here: https://gitlab.com/geometalab/osm-wikidata-quality-checker

EDIT: https://gitlab.com/geometalab/osm-wikidata-quality-checker/-/issues/49

turbotimon commented 6 months ago

Thank you very much! The other two are indeed also already detected by our tool, but unfortunately not reported to Osmose. This is due to a problem we have for a long time with some relations and closed ways for which we currently can't get the coordinates and Osmose requires to send some coordinates. This affects currently about 3% of the detected issues. It is planed to solve this ( #2) for a long time, let's se when i find time to do so..