search

osm-fr / osmose-backend

Part of osmose that runs the analysis, and send the results to the frontend.
GNU General Public License v3.0
90 stars 115 forks source link

False positives in Italy for item 7150 class 12, `Pharmacy without tag ref:msal or invalid` #2223

Open opk12 opened 4 months ago

opk12 commented 4 months ago

analyser_merge_pharmacy_IT.py and analyser_merge_parapharmacy_IT.py match pharmacies from a CSV dataset, based on ref:msal and the coordinates. There are false positives for the CSV rows that lack the coordinates, although OSM has the ref:msal. This is item 7150, class 12, Pharmacy without tag ref:msal or invalid.

For example, this pharmacy has this warning and this CSV row.

20851;00000;Via Sibilla Aleramo, 1/A;Farmacia Villavalle S.N.C.;03673141200;65012;068011;CEPAGATTI;Villareia;068;PE;PESCARA;130;ABRUZZO;01/09/2021;-;Ordinaria;1;-;-;2

It was suggested in the OSM Italy chat on May 9 that the dataset author (Ministero della Salute) is systematically omitting the coordinates for any newly added pharmacies.

frodrigo commented 4 months ago

The issue is not with this analyser, but with the engine that remove data without location before the conflation.

Invalid geom should be keep for matching latter with ref

https://github.com/osm-fr/osmose-backend/blob/dev/analysers/Analyser_Merge.py#L1013