search

osm-fr / osmose-backend

Part of osmose that runs the analysis, and send the results to the frontend.
GNU General Public License v3.0
94 stars 116 forks source link

False positive on "light:colour" values in descriptive color temperature format #2312

Open Lumikeiju opened 3 months ago

Lumikeiju commented 3 months ago

The validator should not flag light:colour values entered as a descriptive colour temperature name (in the format "light:colour"~"amber|daylight|warmwhite|softwhite|neutralwhite|brightwhite|coolwhite|coldwhite"); note that, in fairness, these values are nearly exclusively documented and used by me so far (though currently with >350 uses combined).

Item: 3091 Class: 30914 Subtitle: Unknown or invalid colour in tag 'light:colour' Example: https://osmose.openstreetmap.fr/en/issue/8640d1d3-a360-9673-5459-6524728cd43e

Famlam commented 3 months ago

I must say I'm not really sure if we should support such tags, being highly subjective.

Lumikeiju commented 3 months ago

They're not any more subjective than the standard descriptive colour names which are widely used and supported. These specific values don't have widely-known standard colour equivalents and these values are widely used in the lighting industry - almost all LED bulbs' packaging includes one of these descriptive color temperature names.