Open osm-spiregrain opened 1 day ago
Although we can technically couple NSI to a whitelist in the plugin (we do that in other plugins as well), I think here the NSI is wrong, because also the website of that shop lists it with a space in most places, e.g.
I see you already contacted them: https://github.com/osmlab/name-suggestion-index/issues/10171
Yes - if you read on, the shop doesn't seem to be very clear about it - they use both "H. Samuel" and "H.Samuel" on their website. I've suggested the NSI adopt the space.
My question for the osmose-backend maintainer/contributors is whether NSI entries should in general override 5010 / 902 and similar checks. I hadn't thought of the term 'whitelist', but that's exactly what I meant - so thank you.
I think this check should be country dependent.
Small point, but Osmose and NSI (as used for iD name suggestions) get into a fight when the name in NSI fails the "Initial stuck to the name" check. NSI has the name "H.Samuel", Osmose would prefer "H. Samuel". Should Osmose ignore "Initial stuck to the name" and similar name checks when NSI is asserting a different standardised name when if there is a brand:wikidata set?
Maybe this particular problem (H.Samuel/H. Samuel) should be fixed by fixing the NSI- but should Osmose skip these checks if there is a brand:wikidata set?