search

osm-fr / osmose-backend

Part of osmose that runs the analysis, and send the results to the frontend.
GNU General Public License v3.0
88 stars 111 forks source link

How to avoid "Default and local language name not the same" when name == name:fr in Ontario, Canada #611

Open matthewdarwin opened 4 years ago

matthewdarwin commented 4 years ago

item | 5060 class | 50601

Example: http://osmose.openstreetmap.fr/en/error/32164285602 (way191620645) http://osmose.openstreetmap.fr/en/error/32164286214 (way284785999) http://osmose.openstreetmap.fr/en/error/32164286313 (way323715053)

Situation: Schools, hospitals or any other instributions that are French-speaking should use the "name" tag set the same as the "name:fr" tag, not the "name:en" tag in Ontario. Ontario is presumably English by default (not sure where that is set), but French schools in Ontario should use their French names.

If that is not the issue, then I am not clear on what the problem is.

frodrigo commented 4 years ago

https://github.com/osm-fr/osmose-backend/blob/master/osmose_config.py#L821

Ontario is configured as English. We can set it as multilingual. Multilingual disable some check, but can be flavoured : https://github.com/osm-fr/osmose-backend/blob/master/plugins/Name_Multilingual.py

matthewdarwin commented 4 years ago

I'm not really clear what all that code does, but it would seem to me that allowing "name" to match either "name:en" or "name:fr" for anywhere in Canada would be appropriate.

matthewdarwin commented 4 years ago

It looks like you also support sometimes matching with a separator of " / ", which rarely is used,

name = Ottawa River / Rivière des Outaouais name:en = Ottawa River name:fr = Rivière des Outaouais

matthewdarwin commented 4 years ago

image

Having names like "french common english" is also normal, although it might not be found commonly in tagging due the fact it generates a warning.

name: Complexe récréatif CARDELREC Recreation Complex name:en = CARDELREC Recreation Complex name:fr = Complexe récréatif CARDELREC

https://ottawa.ca/en/news/goulbourn-recreation-complex-now-known-cardelrec-recreation-complex-goulbourn https://ottawa.ca/fr/nouvelles/le-complexe-recreatif-goulbourn-sappellera-desormais-le-complexe-recreatif-cardelrec-goulbourn

frodrigo commented 4 years ago

Adding support of "[en] / [fr]" or "[fr] / [en]" or "[fr] common [en]" can be a new Canadian flavor. The flavors are ways to mix the names for particular regions like Bruxelles, Morocco, Kosovo or Djibouti.

frodrigo commented 4 years ago

It is ok if for first step I just set eastern_ontario as bi-lingual? It will just disable some check on languages