search

osm-fr / osmose-backend

Part of osmose that runs the analysis, and send the results to the frontend.
GNU General Public License v3.0
90 stars 114 forks source link

item 6040 class 802 (INSEE ref for municipality) needs a better behaviour #677

Open Stefal opened 4 years ago

Stefal commented 4 years ago

Hi! 1) This item is dangerous as is because it asks to change the "name" tag on "place" node instead of modifying the admin relation name's tag. See this discussion

2) There are a lot of municipality relation with name and official_name like name=Saint-Martin-derrière-la-colline official_name=Saint Martin derrière la colline

Osmose ask to replace the name with the official one from the COG. As the official name doesn't follow the toponymy rules, I don't think it's a good idea. Maybe this item could check if the COG's name is already in the official name.

Best,

Stefal commented 4 years ago

Please disable this item or hide it on the frontend. We shound remove the ref:INSEE tag from place's node, but in the meantime, this item create more wrong than good contributions.

frodrigo commented 4 years ago
  1. As you propose, I think the data should be cleaned.
frodrigo commented 4 years ago

Removing check on node in progress

  1. Welcome in PR if you want it quickly
frodrigo commented 4 years ago
  1. Done http://osmose.openstreetmap.fr/fr/errors/graph.png?item=6040&class=802
Marc-marc-marc commented 3 years ago

should another analyse target the no-meaning ref INSEE on node ? I mean a fix "delete it because it's not about the place nor the townhall nor a office.." the approved mecanical edit https://lists.openstreetmap.org/pipermail/talk-fr/2019-November/094947.html