osm-fr / osmose-backend

Part of osmose that runs the analysis, and send the results to the frontend.
GNU General Public License v3.0
90 stars 114 forks source link

Mapillary street signs: do not report traffic sign if construction sign is also present in the same image #837

Open Famlam opened 4 years ago

Famlam commented 4 years ago

Quite a few of the Mapillary street signs (especially the speed limits) are the result of temporary road construction. I.e., http://osmose.openstreetmap.fr/nl/error/add9cc28-2eee-f96d-26d4-e155bf09f1e3

Typically such events are short-lived and not worth adding to the map. Perhaps it is possible to detect the presence of the road works sign (Mapillary: Warning: roadworks: g1 and the like) and if present in the same image, ignore that detection?

This would reduce the amount of 'less useful' detections significantly

frodrigo commented 4 years ago

It probably can be done.

didier2020 commented 4 years ago

maybe we can do the job by processing the coordinates whose photos have a sign indicating works

so can i have a part of csv downloaded file https://github.com/osm-fr/osmose-backend/blob/master/analysers/Analyser_Merge_Mapillary.py#L79 ?

frodrigo commented 4 years ago

Look at the Mapillary API. Detection have link to image id. So probably check the other detection of the same image.

didier2020 commented 4 years ago

thanks, found : https://www.mapillary.com/developer/api-documentation/#search-object-detections

didier2020 commented 4 years ago

too hard for me ... in netherlands, bbox=2.900,50.436,7.349,51.884 there is only 200 warning--roadworks--g1

Famlam commented 4 years ago

there is only 200 warning--roadworks--g1

I didn't understand what command to use to get that data, but the city-part Nijmegen-Lent alone already yields around 30 detections in data from the web interface since 2019? I.e. https://www.mapillary.com/app/?lat=51.86190512024879&lng=5.8652657680553375&z=14.080889533600562&dateFrom=2019-01-01&signs=true&trafficSign%5B%5D=warning--roadworks--g3&trafficSign%5B%5D=warning--roadworks--g1

didier2020 commented 4 years ago

it is necessary to have a key ... https://www.mapillary.com/developer/api-documentation/#search-map-features

frodrigo commented 4 years ago

https://github.com/osm-fr/osmose-backend/blob/master/analysers/Analyser_Merge_Mapillary.py#L79

Famlam commented 4 years ago

https://a.mapillary.com/v3/map_features?bbox=2.900,50.436,7.349,51.884&client_id=MEpmMTFQclBTUWlacjV6RTUxWWMtZzo5OTc2NjY2MmRiMDUwYmMw&layers=trafficsigns&per_page=1000&start_time=2018-04-21&values=warning--roadworks--g1&sort_by=key yields 1000 results (which is only because per_page is 1000 I guess)