search

osm-fr / osmose-frontend

Part of osmose that shows results on the website http://osmose.openstreetmap.fr
GNU General Public License v3.0
41 stars 38 forks source link

Suggestion: Always show josm links #261

Open johantiden opened 4 years ago

johantiden commented 4 years ago

As an Android user, I heavily rely on Vespucci for advanced editing. Vespucci is able to intercept josm links, just as josm is designed to do (which really should call for standardization but that is a side note).

The point is that there are possible other use cases for the josm links which are currently blocked by ~checking josm integration~ .

For me, it would be better to disable all checks for josm and just always show the links.

frodrigo commented 4 years ago

Not sure what you talk about.

There is no check about josm.

johantiden commented 4 years ago

From the wiki:

josm – a link to the JOSM editor to load this element; JOSM must be running and the JOSM remote control must be enabled.

I'm assuming this is why I can't see the links on firefox android.

frodrigo commented 4 years ago

The link it is just hidden on touch device (as mobile) https://github.com/osm-fr/osmose-frontend/blob/master/web/static/map/style.css#L231-L235

johantiden commented 4 years ago

OK so let's rephrase the suggestion: "Also show josm links on touch devices".