search

osm-fr / osmose-frontend

Part of osmose that shows results on the website http://osmose.openstreetmap.fr
GNU General Public License v3.0
41 stars 38 forks source link

Enforce username in the query string (byuser page) #333

Closed Crashillo closed 3 years ago

Crashillo commented 3 years ago

Regarding #331 and https://github.com/osm-fr/osmose-frontend/commit/8f1fcbc10d51be79acd073fff87b68f097533b9f

If you remove the username=${username} from the query string, you may miss the user param. Since you're at byuser page, the link should have always this param.

frodrigo commented 3 years ago

But if there is no username the index page should be displayed http://osmose.openstreetmap.fr/en/byuser/

Crashillo commented 3 years ago

There's no problem with that, look at the nav_link computed property. The username parameter is enforced only for the Map link, nothing else.

frodrigo commented 3 years ago

Ok. I got the point. Thank you.