Refactor xml export descriptions

osm-fr / osmose-frontend

Part of osmose that shows results on the website http://osmose.openstreetmap.fr

GNU General Public License v3.0

41 stars 38 forks source link

Closed gileri closed 3 years ago

gileri commented 3 years ago

Fixes #155, #339

frodrigo commented 3 years ago

Argh. No. I just move out from template.

I plan to drop template support and even bottle.

gileri commented 3 years ago

So what approach would you suggest ? Rendering HTML by concatenating strings is not really enjoyable nor readable.

frodrigo commented 3 years ago

Maybe using lxml again and dump it as string into the xml.

gileri commented 3 years ago

Are the template OK before I rewrite them ? I'd like to avoid rewriting them thrice ;)

frodrigo commented 3 years ago

Content look ok for me. Be the layout have to be tested in readers.

gileri commented 3 years ago

lxml and string concatenations are now used render the XML descriptions. The feed is also now valid according to the W3C feed validator.

Before : Before

After : After

frodrigo commented 3 years ago

@jocelynj what do think about the .pot update ?

jocelynj commented 3 years ago

@jocelynj what do think about the .pot update ?

The change seems fine. Could somebody check that running "make" keep the changes?

gileri commented 3 years ago

Could somebody check that running "make" keep the changes?

If that helps that's what I did to obtain those changes.

frodrigo commented 3 years ago

Thank you.

Deployed.

jocelynj commented 3 years ago

@gileri : I'm getting an issue when launching make here. Do I need to run npm before launching it?

% make
find: ../../web_api/views: No such file or directory

frodrigo commented 3 years ago

This PR does not change how the .pot is generated. On the the .pot file.