search

osm-fr / osmose-frontend

Part of osmose that shows results on the website http://osmose.openstreetmap.fr
GNU General Public License v3.0
41 stars 38 forks source link

Better po workflow #341

Closed gileri closed 3 years ago

gileri commented 3 years ago

Small tweaks to help run cd web/po && make. Don't hesitate to make comments, I'm not very familiar with this.

See https://github.com/osm-fr/osmose-frontend/pull/340#issuecomment-846607645

frodrigo commented 3 years ago

Not tested, but look good to me.

jocelynj commented 3 years ago

Thanks for the fix.

I didn't know that "../../web_api/views" was no longer necessary. Is it because templates were removed from frontend?

frodrigo commented 3 years ago

I didn't know that "../../web_api/views" was no longer necessary. Is it because templates were removed from frontend?

Yes, all template left.

jocelynj commented 3 years ago

I've tested your changes, and they work correctly.

A suggestion: could we detect that ../node_modules/easygettext/src/extract-cli.jsis not installed, and launch a "npm install" command to install it? Something like:

mv package.json package.json.bak
npm install --no-package-lock --no-save easygettext@2.17.0
mv package.json.bak package.json
frodrigo commented 3 years ago

I've tested your changes, and they work correctly.

A suggestion: could we detect that ../node_modules/easygettext/src/extract-cli.jsis not installed, and launch a "npm install" command to install it? Something like:

mv package.json package.json.bak
npm install --no-package-lock --no-save easygettext@2.17.0
mv package.json.bak package.json

easygettext is a dev dependancy. Dev deps from package.json should be installed..

gileri commented 3 years ago

A suggestion: could we detect that ../node_modules/easygettext/src/extract-cli.jsis not installed, and launch a "npm install" command to install it?

I added a commit that suggest the user to install dependencies, what do you think ?

frodrigo commented 3 years ago

Thank you all.