osm-fr / osmose-frontend

Part of osmose that shows results on the website http://osmose.openstreetmap.fr
GNU General Public License v3.0
41 stars 38 forks source link

A large number of edits create an empty changeset #380

Open deevroman opened 2 years ago

deevroman commented 2 years ago

If you create an edit package with 100-200 edits, only an empty edit package is created. No error messages appear.

Example changesets: https://osmcha.org/changesets/123314632 https://osmcha.org/changesets/123337130

frodrigo commented 2 years ago

The edge case of conflict is not supported. Do you think it is your case ?

deevroman commented 2 years ago

I have an idea how to repeat the bug, but without logs it's pretty useless:(

The assumption is the following: I fixed in both cases only redirects thrust wikidata in http://osmose.openstreetmap.fr/en/map/#item=3031&class=1%2C2%2C3%2C4%2C5%2C6%2C7%2C8%2C9&zoom=7&lat=53.212&lon=38.529&level=1%2C2%2C3&issue_uuid=7f5fbb48-f33a-58c7-90bf-7d676d3ee09a (That is, these edits only affected the wikidata tag)

The following bug sometimes appears on the site: if you solve problems on one zoom, then change the zoom, then some of the problems may reappear. Maybe I solved these problems again and when sending it caused a conflict.

frodrigo commented 2 years ago

The following bug sometimes appears on the site: if you solve problems on one zoom, then change the zoom, then some of the problems may reappear. Maybe I solved these problems again and when sending it caused a conflict.

It is a cache issue, to improve server size perf. It is expected. The cache is about 5s.

I don't get any error messages

It is a know issue of no dealing with conflicts.

A solution, if it is this problem. Is to save often. It stay anyway in the same changeset.

deevroman commented 2 years ago

The cache is about 5s.

Markers continue to appear on other zooms for much longer than 5 seconds (over a minute)

It is a know issue of no dealing with conflicts.

The problem of conflicts and the lack of error messages are different problems (if I am translating your messages correctly. Is there an issue on this?)

Is to save often.

Maybe inform the user about it? For example, highlight the save button.

fgouget commented 2 years ago

A solution, if it is this problem. Is to save often. It stay anyway in the same changeset.

That does not work. I lost changesets with less than 20 modifications which is really not much when fixing addr:street fields. Given its current state Osmose should display a warning telling people not to make changes as there is, in my experience, a > 30% probability their work will be lost.

GreenAloe commented 1 year ago

I was fixing tags a few hours, saved changes from time to time but did not checked if it was saved. But now I see that only a few changesets were saved. Almost all changes were lost :(

frodrigo commented 1 year ago

I was fixing tags a few hours, saved changes from time to time but did not checked if it was saved. But now I see that only a few changesets were saved. Almost all changes were lost :(

Sorry to hear that. The upload to osm.org must be reworked. Prior works are already in progress (by slowly).

fgouget commented 1 year ago

I also lost about 60 changes last week. Osmose has silently been unusable for a couple of months now :-(

frodrigo commented 5 months ago

Now Osmose report an error. But the error message does not yet contain if it is about conflict or not.

HubMiner commented 5 months ago

Thinking how to avoid big changes... Would it be easier to dump conflict details into browser console add maybe a GUI message to check console?

frodrigo commented 5 months ago

Thinking how to avoid big changes... Would it be easier to dump conflict details into browser console add maybe a GUI message to check console?

The UI already display the message send by the API. But the API only send a generic message.