osm-fr / osmose-frontend

Part of osmose that shows results on the website http://osmose.openstreetmap.fr
GNU General Public License v3.0
41 stars 38 forks source link

Class filtering doesn't work #384

Closed Ptigrouick closed 2 years ago

Ptigrouick commented 2 years ago

On item=7170 when I try to filter with class=1, I get all items and not only those of class=1. I think class filtering don't work anymore.

frodrigo commented 2 years ago

Do you have more details. Because it looks fine to me https://osmose.openstreetmap.fr/en/issues/open?item=7170&class=1

Ptigrouick commented 2 years ago

The problem seems to occur only on the map, not the list. https://osmose.openstreetmap.fr/en/map/#item=7170&class=1&zoom=11&lat=43.6168&lon=3.6982&level=1%2C2%2C3 2022-07-21_22-55_osmose I get all classes of item 7170, not only "route potentiellement manquante à proximité (BD Topo IGN)". I did a big clean of class=1 on my area and 3 days ago I saw all items with the same URL.

frodrigo commented 2 years ago

On the switch to FastAPI the parameter was renamed classs (3 x s). While the API use class.

So the current class parameter is not read.

I do not see how to fix it cleanly. I ask for help https://github.com/tiangolo/fastapi/discussions/5184

(http://beta.osmose.openstreetmap.fr/api/0.3/issues/11/1045/745.geojson?item=7170&level=1%2C2%2C3&class=1)

frodrigo commented 2 years ago

Fixed.