search

osm-fr / osmose-frontend

Part of osmose that shows results on the website http://osmose.openstreetmap.fr
GNU General Public License v3.0
41 stars 38 forks source link

SIRENE report from Shop_FR issues do not resolve #390

Open FredericBourgeon opened 2 years ago

FredericBourgeon commented 2 years ago

It seems that items 8310 - Shops contain a link to the SIRENE database in France. Although the SIRET code is functionnal, the link in the modal window does not return result from the SIRENE database. Instead, an almost blank page is loaded.

frodrigo commented 2 years ago

Same as #335 ?

vinber commented 1 year ago

Example http://osmose.openstreetmap.fr/fr/map/#item=8310%2C7210&class=6803126&zoom=17&lat=43.649433&lon=-1.406808&level=1%2C2%2C3&issue_uuid=a95bdc81-638c-4a66-4098-418f7e81f905

ref:FR:SIRET = 33982496300047

currently 1 SIRET (14 digits) refers to https://avis-situation-sirene.insee.fr/ListeSiretToEtab.action?form.nic=00047&form.siren=**339824963**

i think it's better to resolve to https://annuaire-entreprises.data.gouv.fr/etablissement/33982496300047

or if we "prefer" insee.fr we can use https://api.avis-situation-sirene.insee.fr/identification/pdf/33982496300047

vinber commented 1 year ago

i think https://github.com/osm-fr/osmose-frontend/pull/418/commits/dc3232f136b953a61cfa8588030e45fbb78d0866 it's to change to https://annuaire-entreprises.data.gouv.fr/etablissement/33982496300047