osm-fr / osmose-frontend

Part of osmose that shows results on the website http://osmose.openstreetmap.fr
GNU General Public License v3.0
41 stars 38 forks source link

Support offline issue download from API #404

Open frodrigo opened 1 year ago

frodrigo commented 1 year ago

To support offline

Helium314 commented 1 year ago

Thanks for creating this issue.

To make clear why I asked in https://github.com/Helium314/StreetComplete/issues/384: I implemented an Osmose quest in my fork of StreetComplete, which essentially just shows available issues and allows editing element tags (if an element is associated with the issue). Since StreetComplete is supposed to work offline (downloading all data inside a bbox, which align with zoom 16 tiles), all Osmose issues in the downloaded bbox are downloaded too (currently using CSV, which contains sufficient data except fixables).

However, as part of solving https://github.com/Helium314/StreetComplete/issues/384 (creating nodes with tags in fixable), also the fixable tags are needed. I see 3 ways of doing this:

  1. switch to semi-online: download each issue once the user opens the corresponding quest
  2. stay offline with current possibilities: in addition to downloading the bbox, do another download with fixable=online (or josm?) and download each of the returned issues. This means that at least twice as many requests are sent, and potentially many many more. I assume this is not wanted from Osmose side due to extra server load (and I don't like it because it may slow download significantly if connection is bad or server is busy)
  3. stay offline with only one download: This would require the possibility of downloading issues with using the proposed API call
mnalis commented 1 year ago
  1. stay offline with only one download: This would require the possibility of downloading issues with using the proposed API call

That would seem like best solution to me too. Is there any interest from Osmose side to have such functionality?

frodrigo commented 1 year ago
  1. stay offline with only one download: This would require the possibility of downloading issues with using the proposed API call

That would seem like best solution to me too. Is there any interest from Osmose side to have such functionality?

Yes. But lack of time. Help and PR welcome.