search

osm-fr / osmose-frontend

Part of osmose that shows results on the website http://osmose.openstreetmap.fr
GNU General Public License v3.0
41 stars 38 forks source link

Require confirm before marking as false positive #457

Closed Famlam closed 1 year ago

Famlam commented 1 year ago

When marking an issue from the map as a false positive, you'll have to confirm this every time via a pop-up. https://github.com/osm-fr/osmose-frontend/blob/00f26b2d6d265519ca7abb01aa1fe7b80b515cf2/web/src/pages/map/popup.vue#L398-L402

However, in the issue list (example) or user detection list (example) there's no confirmation after clicking the ✘-button, allowing some people to mark the entire list as false positives within minutes (some analysers have over 20 false positives marked within 1 minute, all by one user). This is very likely by users who don't understand that the false positive marking is not to hide it from their own list, but to hide it for everyone.

Proposed solution: make the user confirm that (s)he really wants to mark the issue as false positive and has at least read the implications, by requiring the same confirmation popup to be "OK"ed in the issue list, similar to marking an issue as false positive in the map view

frodrigo commented 1 year ago

Good point.

I also suggest replace the confirm dialog text from

Report the issue as improper, if it is not an issue according to you. The issue will not be displayed to anyone anymore.

to

Report the issue as improper. Use only if the Osmose reported issue is in fact not an OSM data issue. Warning, the issue will also no more displayed to other contributors. If you are unsure, let this Osmose issue open. If Osmose reports lots of think like this one and you are disagree with this, please fill an Github bug issue and let us try to fix it.

Famlam commented 1 year ago

I agree, that is much better. Just fixed some wording here:

Report the issue as improper. Only use this if the issue reported by Osmose is in fact not an issue in the OSM data. Warning: the issue will also no longer be displayed to other contributors. If you are unsure, let this Osmose issue open. If Osmose reports lots of issues similar to this one and you disagree with this, please fill a Github issue and let us try to fix it.

p.s. I haven't been able to build the frontend yet (Windows 😇) and I'm not familiar with vue, so I'll have to leave it to you to implement this 🙈

frodrigo commented 1 year ago

I agree, that is much better. Just fixed some wording here:

Thank you.

Done and deployed.

p.s. I haven't been able to build the frontend yet (Windows innocent) and I'm not familiar with vue, so I'll have to leave it to you to implement this see_no_evil.

The JS part is the easier part to run. It can be done without docker.