Fixes are not saved immediately

osm-fr / osmose-frontend

Part of osmose that shows results on the website http://osmose.openstreetmap.fr

GNU General Public License v3.0

41 stars 38 forks source link

Fixes are not saved immediately #487

Closed HubMiner closed 6 months ago

HubMiner commented 7 months ago

I made a few separate fixes a few minutes ago, and saved multiple times - I should endo up with multiple changesets. JOSM "close open change sets" says: There are no open change sets. My user history shows that the last fix was 6 hours ago.

frodrigo commented 7 months ago

Change are send directly to the API. I'm afraid the the changes are lost. Should be an issue with the recent switch to OAuth2.

HubMiner commented 7 months ago

Bonjour & thanks for looking into this!

I tried to:

logout & login (both steps were slow: 20+ seconds),
fixed one issue,
saved the changes.

Result: same behavior, no changeset.

Please let me know if there are suggested workarounds, if there is anything I could do to reset my authentication.

frodrigo commented 7 months ago

I have not yet identifier what append. The OSM.org API may accept or not the changeset upload process. When nothing is uploaded, it create anyway empty changeset. It may not be linked to the OAuth2 changes.

Bad think is that the Osmose code fails silently on this. I will try first to fix this point.

frodrigo commented 6 months ago

Bad think is that the Osmose code fails silently on this. I will try first to fix this point.

Not it shows an error when it fails.

frodrigo commented 6 months ago

I found the source of the issue. An UTF-8 encoding issue. I have deployed a fix.

I don't know why and when it could have been broken. But is was not directly linked to OAuth2. May come from dependencies update when switching to OAuth2.