Cleanup and refactor - Githubissues

osm-in / flood-map

A simple web map to visualize flood information on maps

http://osm-in.github.io/flood-map/

MIT License

94 stars 73 forks source link

Cleanup and refactor #26

Closed arunasank closed 6 years ago

arunasank commented 6 years ago

Break down the code into several functions
Dump JSON in separate files and load these in the first script we are using
Make functions tiny, concise and unitary
Add eslintrc

cc/ @planemad @geohacker @batpad

arunasank commented 6 years ago

@batpad I requested a review from you w/o checking with you beforehand. Are you free to take a stab at reviewing this?

batpad commented 6 years ago

@arunasank this looks great, thank you so much for taking this on! Going to drop a few comments - but I also feel this is better than what we currently have, so please take review comments as optional / not a blocker to merge, if everything seems to work.

arunasank commented 6 years ago

@batpad thank you so much for taking the time. : 💓 all comments look great - will make fixes today and pass it along for a second review. I tested the code quite a bit, and did not find any issues. Will do that some more today too.

arunasank commented 6 years ago

I feel good about merging this. I've tested the map functionalities for

Selecting, deselecting the road
Going to areas from the list on the left, and also the reset functionality.
Highlighting geographic features, from the features list on the left, and reset.
Change in the count of roads when selected/deselected.

Thanks again @batpad! 🙇‍♀️