search

osm-pl / osm24

Opening hours using OpenStreetMap data
https://osmapa.pl/osm24/
Other
2 stars 2 forks source link

Consider adding "modern" JS pipeline & stack #9

Open prmtl opened 6 years ago

prmtl commented 6 years ago

I was thinking about adding some "modern" pipeline to the project, to make writing code more pleasant. What I mean by that: right now it is written in plain ES5 which is missing some neat features. I thought about porting it piece by piece to ES6 but it would require to use tools like Babel transpiler, npm or yarn for installing dependencies, etc.

This would complicate initial setup and updates on the server which IMHO is a big obstacle.

Also the stack would case a higher entry level for potential contributors, since it is easier to write some spaghetti JavaScript full of jQuery than learn first about dependency management with npm/yarn

kocio-pl commented 6 years ago

I don't know if you're aware that @Dotevo is working on the new code, probably https://github.com/dotevo/osm24/tree/osm24v2 is the basic of this. If you want something modern, you can talk to him, I guess. This is a legacy fork and I'm even not a coder, but if you want to develop it into something modern, it's perfectly possible.

prmtl commented 6 years ago

Yes, I'm aware of it.

OK, so if there is no strong voice against it (moving to some "modern" stack), I'll slowly work on it.

dotevo commented 6 years ago

osm24v2 is not this what I'm doing right now. It is dead branch. I keep project on private repository. It is uses npm + gulp ES6 etc. But I'm not sure if I will publish it - or maybe yes but when will be ready. But project is not created in English so I do not think that anyone will want to contribute to it XD

kocio-pl commented 6 years ago

If it will be interesting, it can be simply translated into English.

But given that you're not sure yet, modernizing osm24 makes perfect sense for me.

BTW @prmtl ask for joining osm-pl team so you can merge the code yourself.

kocio-pl commented 6 years ago

This fork had very simple goal - cleaning a bit and adding Polish translation. I didn't expect that someone else might be so interested. So I think of making all the basic stuff and make it 1.0.0 release to state it clearly and then move forward with a full blown rework.

prmtl commented 6 years ago

@kocio-pl Cool, AFAIK someone just need to add me to collaborators, no way to "ask to join".

kocio-pl commented 6 years ago

I thought that I have no such right, but it looks that I have. I have added you and now the invitation needs to be confirmed by you.

kocio-pl commented 5 years ago

Hi! If you feel like, you can do whatever you want - it does not look like anything is going on with this code for a year and I don't want to block you.