osm-quality / OSM-wikipedia-tag-validator

Python script validating Wikipedia tags in OpenStreetMap database by fetching and analysing linked Wikipedia articles.
GNU General Public License v3.0
14 stars 4 forks source link

Feature Wish: Map view of the issues #14

Open mcliquid opened 1 year ago

mcliquid commented 1 year ago

Very similar to the "Osmoscope" tool from BRouter suspects, I would find it very helpful to be able to view the problems on a map. Example: http://brouter.de/osmoscope/#map=8/13.12866/47.2233&op=1&l=http://brouter.de/osmoscope/tertiarynew.json Repository: https://github.com/osmoscope/osmoscope-ui BRouter suspects: https://brouter.de/brouter/suspects/

If it can be set up with manageable effort, that would be a great addition to the tool.

matkoniecz commented 1 year ago

Someone else requested already reports in JSON or other format. Maybe it will be possible to make map straight from them? But it may hit some performance issues.

Either way, when data will be published in machine readable form anyone can relatively easily make map out of it (or maybe not? not sure is latitude/longitude going to be included)

matkoniecz commented 1 year ago

And in general I planned this for a looooong time, in large part to visualise cleanup in Poland and in my area specifically and compare it with other areas but so far every time something more interesting/important is appearing when I have time to improve this project (right now it is "make more MR tasks, test ones that I created are fully processed")

(and this specific project is part of my hobby time which is part of my overall activities)

mcliquid commented 1 year ago

I've just played around with the austrian data and loaded them via overpass turbo and exported the geojson file to geojson.io Source data: https://matkoniecz.github.io/OSM-wikipedia-tag-validator-reports/%C3%96sterreich%20(Austria).html#wikipedia%20wikidata%20mismatch Overpass Turbo: https://overpass-turbo.eu/s/1qkd

I can't share a geojson.io url but it's possible to have all POIs on a map: image

It would now probably need an automatic conversion of the data into a geojson (via overpass api?) and then displaying the geojson on a map (Osmoscope?). geojson.io is missing the possibility to edit the object.

matkoniecz commented 11 months ago

partially done via https://maproulette.org/browse/projects/53065 - but it is split per error type, not in a single unified view

matkoniecz commented 11 months ago

PR would be welcome.

Note that https://github.com/matkoniecz/OSM-wikipedia-tag-validator/blob/master/maproulette_challenge_creation.py already produces geojson so ideally code would be reused.

Note build_geojson_of_tasks_to_add_challenge function at https://github.com/matkoniecz/OSM-wikipedia-tag-validator/blob/master/maproulette_challenge_creation.py#L619

Initial version can support nodes/ways without relation support (like MR share works now).

Let me know if anyone would be interested and got stuck on something - that would motivate me to refactor/document/whatever the code.

matkoniecz commented 11 months ago

(that is actually relatively simple to do, I just run out of time to do it)