search

osm-quality / OSM-wikipedia-tag-validator

Python script validating Wikipedia tags in OpenStreetMap database by fetching and analysing linked Wikipedia articles.
GNU General Public License v3.0
14 stars 4 forks source link

check for species should match breed to? #17

Open mnalis opened 8 months ago

mnalis commented 8 months ago

e.g. node 7522860740 has species:wikidata=Q65127034 but that goes down to more specific animal breed (P4743) i.e. more precise species.

Validator complains with no matching P105, but my wikidata-fu is too low to determine if that is because of P4743 wikidata entry needing some linkage to P105, of just something that this validator should do (i.e. accept "breeds" to be specified under species:wikidata too, as it seems common practice to specify specific breed details when known instead of more coarse species taxon; and there is no breed:wikidata OSM tagging).

matkoniecz commented 8 months ago

Lets ignore Wikidata for now.

Is species:wikidata (and species) supposed to be used for breeds? Or is it invalid use?

I have no good idea. Is it documented/discussed anywhere?

matkoniecz commented 8 months ago

I will hide

        "species secondary tag links something that is not species according to wikidata (checking P105)",
        "genus secondary tag links something that is not genus according to wikidata (checking P105)",

until this is clarified.

Once next update runs this errors will not be listed anymore.

mnalis commented 7 months ago

Is species:wikidata (and species) supposed to be used for breeds? Or is it invalid use?

I don't know if it was originally intended, but it seems to have (non-insignificant?) use in the wild.

I have no good idea. Is it documented/discussed anywhere?

https://wiki.openstreetmap.org/wiki/Key:taxon seems to have some details about the issue of flexibility of taxonomy, and I seem to have read somewhere some more (not links at hand, though). AFAIR, the issue seems to be that what is actually considered "species" might vary depending on whom you ask.

But biology is definitely not my field, so I'm afraid I cannot really provide much more info than that.

matkoniecz commented 7 months ago

I guess it is going to wait until documentation is more clear - or at least it was discussed at OSM Community forum.

Please oping me once it happens and it is clear what should be done here!

ivanbranco commented 7 months ago

species=* should be used for species only. I would change this with species=Gallus gallus and move the breed to taxon=Dalmatinska kokoš, which is the jolly tag for other taxonomies (so we don't have 10000 different tags).

matkoniecz commented 7 months ago

Is it documented/discussed somewhere?

matkoniecz commented 5 months ago

ping @ivanbranco - is it documented/discussed somewhere? It accepted by community in general to restrict it in this way?