search

osm-quality / wikibrain

Stores knowledge and data necessary to properly use links from OpenStreetMap to Wikipedia, Wikidata and Wikimedia Commons.
MIT License
4 stars 1 forks source link

test_that_wikidata_works_with_multiple_brands_one_invalid failing #6

Closed matkoniecz closed 8 months ago

matkoniecz commented 8 months ago 
======================================================================
FAIL: test_that_wikidata_works_with_multiple_brands_one_invalid (test_wikimedia_link_issue_reporter.Tests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/mateusz/Documents/install_moje/OSM_software/wikibrain_py_package_published/test_wikimedia_link_issue_reporter.py", line 490, in test_that_wikidata_works_with_multiple_brands_one_invalid
    self.assertIsNone(should_be_fine)
AssertionError: <wikibrain.wikimedia_link_issue_reporter.ErrorReport object at 0x7f24aa898d90> is not None

Given that https://www.wikidata.org/wiki/Q7501155 is actually defunct, it should not be None, right? And if one would be invalid then error should be still emitted?

@KasperFranz

from #5

KasperFranz commented 8 months ago

The test case was wrong - I will create a PR to fix it shortly

matkoniecz commented 8 months ago

Thanks!

@KasperFranz I invited you with triage rights to this repository, feel free to join if you want (and for some obscure reason I needed to move it to personal organisation from personal account to achieve this, hopefully nothing got mangled by this)

KasperFranz commented 8 months ago

Thanks!

@KasperFranz I invited you with triage rights to this repository, feel free to join if you want (and for some obscure reason I needed to move it to personal organisation from personal account to achieve this, hopefully nothing got mangled by this)

Interesting, I am not sure what the triage role gives, but thank you :)

matkoniecz commented 8 months ago

I am not sure what the triage role gives

1) you can close/reopen/label all issues

2) you can be assigned to issues (so it was a trap :) )