osm-search / Nominatim

Open Source search based on OpenStreetMap data
https://nominatim.org
GNU General Public License v3.0
3.12k stars 714 forks source link

Indexing of named entrances #2833

Open westnordost opened 2 years ago

westnordost commented 2 years ago

What did you search for?

Tor 3, REYHER, Hamburg

What result did you get?

None

What result did you expect?

https://www.openstreetmap.org/node/9396927629

Further details

REYHER, Hamburg returns the expected result: The company premises of Reyher. So, Nominatim has the ability to find objects independent of addr:* tags and also has some notion of which objects are contained in other objects. Gates (on the outline of such objects) with either name or ref seem to not be regarded, however.

lonvia commented 2 years ago

barrier=* objects are not indexed at the moment.

lonvia commented 1 year ago

Note that this issue comes out of a discussion on the German forum: https://community.openstreetmap.org/t/pforte-wie-eintragen/3047 Unfortunately there wasn't any usable conclusion there.

One thing is indisputable: Nominatim currently does not index named entrances/gates. That should be changed.

Looking at the example and other named barrier=gate I wonder though, if the barrier object is the right one to have the name. Isn't it rather the overall entrance which is named.

So the question is: should barrier=gate be indexed (none of the other barrier values are really make sense to be named, so it would be the exception) or entrance=*?

westnordost commented 1 year ago

Isn't it rather the overall entrance which is named.

What do you mean? How would the overall entrance (to fenced company premises) be tagged if not as a barrier=gate?

I was under the impression that entrance=* is rather only used on building entrances, not on fences and walls. At least in German, an "entrance" through a fence would always be called a "gate", no matter the size.

lonvia commented 1 year ago

What do you mean? How would the overall entrance (to fenced company premises) be tagged if not as a barrier=gate?

A barrier=gate is strictly speaking only the 'section in a wall or fence which can be opened to allow or restrict access'. An entrance (or the German 'Tor' you refer to here) may be comprised of more than just that movable part. The referenced discussion mentions a gate house as an example. Or think about the huge multi-gate entrances to zoos.

So entrance=* is the metaphysical concept of 'go here to get access or leave from the premises' while barrier=* describes the physical structure that is there.

I was under the impression that entrance=* is rather only used on building entrances, not on fences and walls.

It's mostly used on buildings but there is no restriction there. The wiki says 'point where you can go into a building or enclosed area (such as a zoo, theme park, cemetery grounds etc)'.

At least in German, an "entrance" through a fence would always be called a "gate", no matter the size.

The German word 'Tor' can be used in the metaphysical sense of 'gateway'. That part is not covered by barrier=gate.

westnordost commented 1 year ago

There is no way to tag the whole entrance area (gate + gate house etc) of an entrance though, as far as I know.

But if the tagging reality is that barrier=gate for company premises entrances is only really used in German speaking countries due to concept of a Gate in the language, then maybe it is not worth to support (globally). And if it is common (in other countries) to tag such premises entrances as entrance=* then entrance=* should be indexed, too.

If you are unsure about the prevalence in tagging of either, maybe this needs some research to find out which tagging is really used in such cases.

matkoniecz commented 1 year ago

Other tagging, the same issue:

Wrocławska 53d, Kraków finds https://www.openstreetmap.org/way/571349204

Wrocławska 53d I, Kraków fails to find https://www.openstreetmap.org/node/8923353884 (entrance=staircase ref=1)