search

osm-search / Nominatim

Open Source search based on OpenStreetMap data
https://nominatim.org
GNU General Public License v3.0
3.11k stars 713 forks source link

Make hard-coded list of output name tags configurable #3416

Open lonvia opened 4 months ago

lonvia commented 4 months ago

Which name is chosen for a place is currently determined from a hard-coded list of tag names at https://github.com/osm-search/Nominatim/blob/7f0d969d71a09cac63a2a916554427627ca399bc/nominatim/api/localization.py#L26

This list should become configurable. The current hard-coded list should then get a config option like:

NOMINATIM_OUTPUT_NAMES = name:XX,name,brand,official_name:XX,short_name:XX,official_name,shirt_name,ref
kitsiosvas commented 2 weeks ago

Hello @lonvia , is this issue still relevant? Would like to contribute if so

mtmail commented 2 weeks ago

@kitsiosvas Two other user already started, you can see their PRs and our comments to them. https://github.com/osm-search/Nominatim/pull/3451 and https://github.com/osm-search/Nominatim/pull/3486. So far the situation is that the users didn't understand the task and started coding, which likely won't be successful.

I'd suggest to look at https://github.com/osm-search/Nominatim/issues/235 instead. Let us know if you have questions on that issue page.