Closed mtmail closed 3 weeks ago
I would suggest that we always rely on an external osm2pgsql for the tests. It will simplify the code a bit.
I'm in the middle of porting the code to psycopg3 which has quite some code changes around the BDD setup code. So I would prefer to defer this issue until after the psycopg upgrade is through.
Ok, so I delay the PR. The symlink works just fine in the meantime.
So for the time being we still need the build directory when testing against the legacy tokenizer. I'll do a PR where the default for the build directory is None but you can still set it directly.
The other solution would be to just drop the legacy tokenizer with the next version. I'm seriously tempted to go down that road because it already is somewhat broken and the CI didn't properly catch it.
https://github.com/osm-search/Nominatim/pull/3458 notes "osm2pgsql will no longer be bundled with Nominatim when installing with pip."
The test suite still looks only in the build directory for osm2psql.
Should it look for system-wide installed osm2psql if the
build_dir
doesn't exist? Or should the documentationdocs/develop/Development-Environment.md
be updated instead? (I just created a symlink and that worked)