osm-spline / xappy.js

Xappy.JS
Other
37 stars 4 forks source link

should eventEmitter send a "start" signal? #34

Closed andreasnuesslein closed 13 years ago

andreasnuesslein commented 13 years ago

currently response.js receives "node" "way" "relation" or "end".

response.js then checks if a header has already been sent and if not does so once.

QUESTION: should we explicitly send a "start"-event with our emitter and thereby put the logic into the emitter?

eventEmitter would then send:

  1. start 2.-(n-1). node | relation | way n. end
mren commented 13 years ago

we have an end event, a start event seems to be logical this has also the advantage, that the generators can send the header of the data and we dont need the logic in response.js anymore.

i implemented the start event in 089f9c998d895d19ab4ef4091a81a4267386f656 as this does not break existings logics

mren commented 13 years ago

i added this issue on sprint 1