osm-spline / xappy.js

Xappy.JS
Other
37 stars 4 forks source link

rowparser.rowToObject has unexpected behaviour #89

Closed mren closed 8 years ago

mren commented 13 years ago

what should happen if type is not in object? there was a log.warn before, i added a throw which seems to me more plausible, but can break the whole app.

how should we handle unexpected behavior in rowToObject?

booo commented 13 years ago

I'm not sure how to handle this. I think we define the three types of rows and there shouldn't be an other type of row we have to handle with an exception. Otherwise this would mean our design is broken.

Are there any best practice examples for this kinds of problems?