search

osm-uk / NI-Postcodes

BSD 2-Clause "Simplified" License
0 stars 1 forks source link

Well formed postcodes #2

Closed Cj-Malone closed 3 years ago

Cj-Malone commented 3 years ago

Currently the some of the postcodes are "malformed", with missing spaces, or lowercase. I want to format existing data and make sure new data is formatted.

gregrs-uk commented 3 years ago

You may want to have a look at the approach I used to validate FHRS postcodes in FHODOT. See https://github.com/gregrs-uk/fhodot/blob/39e1d2dad079405de66dae4a378a8ea9dc35c518/fhodot/models/fhrs.py#L23-L28 and https://github.com/gregrs-uk/fhodot/blob/39e1d2dad079405de66dae4a378a8ea9dc35c518/fhodot/models/fhrs.py#L170-L198

Cj-Malone commented 3 years ago

Fixed in e5421099c0fcc439198ef131f3a5fde308d7cae3 and a42c0fe832702921a0609b3abf04b4be7490f927. The "O" in the inwards code is a nice catch. Thank you.