Remove special case for old PostGIS versions when clustering

osm2pgsql-dev / osm2pgsql

OpenStreetMap data to PostgreSQL converter

https://osm2pgsql.org

GNU General Public License v2.0

1.48k stars 473 forks source link

Remove special case for old PostGIS versions when clustering #2188

Closed joto closed 3 months ago

joto commented 3 months ago

Ordering by geometry was done differently before PostGIS 2.4. This commit removed the old code and adds a check that PostGIS 3 is available.

For this specific case a check for PostGIS 2.4 or above would be sufficient, but PostGIS 3 is available for a long time now (it is in Debian Bullseye ("oldstable", released 2021) and Ubuntu 20.04).

lonvia commented 3 months ago

The minimum version of PostGIS we test for in the CI is 2.5. So this should also be the minimum supported version. I'd keep the PR as is and leave in the test but test for >=2.5 instead.

joto commented 3 months ago

I have updated the commit to check for 2.5 instead of 3.