osmanaliyardim / WebNetSample

Epam WEB .NET Mentoring Program
MIT License
0 stars 0 forks source link

FEAT: Optional Logging #10

Closed osmanaliyardim closed 1 year ago

osmanaliyardim commented 1 year ago

Task 5 - Filters

What this change does

Focus on why the change was made and provide short, clean and good summary

  • Added optional logging open/closed functionallity.

Code changes

Explain what files and code parts were changed in scope of PR and reviewer should pay attention for

  • Added new properties to LoggerServiceBase class on Core Layer under Logging file.

What has been done to confirm PR works and does not break existing stuff

Provide guarantees that your change does not ruin existing functionality and works as expected

  • Tested on localhost.
osmanaliyardim commented 1 year ago

Regarding AC in this task you should add Action Filter which injects your ILogger and logs actions request/response items based on your param settings

My logger was already an Action Filter as AOP before. So that this code change doesnt include what you mentioned I guess. Can you check again? Do I need to implement it in Controller?

dotnet-fizzyy commented 1 year ago

Regarding AC in this task you should add Action Filter which injects your ILogger and logs actions request/response items based on your param settings

My logger was already an Action Filter as AOP before. So that this code change doesnt include what you mentioned I guess. Can you check again? Do I need to implement it in Controller?

Could you, please, attach screenshot how does your log of request look like?

osmanaliyardim commented 1 year ago

Regarding AC in this task you should add Action Filter which injects your ILogger and logs actions request/response items based on your param settings

My logger was already an Action Filter as AOP before. So that this code change doesnt include what you mentioned I guess. Can you check again? Do I need to implement it in Controller?

Could you, please, attach screenshot how does your log of request look like?

Can you please check this commit? And also see the attached logged json file, please.

loggingToJson