Application enhancements requirements [WebApi, WebNetMVC]

[dotnet-fizzyy]

Note: Create a separate PR with fixing all comments I left in this comment, please

File structure:

• It looks like you have removed this folder using file explorer, but reference in solution still exists. Please, remove it: The same case for wwwroot/Images folder.

Code issues for WebNetMVC:

• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebNetSample/Controllers/CategoriesController.cs#L5 - Namespace does not meet real folder storage. Try to avoid such issues, it may lead to namespaces mismatching and difficulties with file structure comparison (namespace = file location in folder structure). Update this case in your solution for all files;
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebNetSample/Controllers/ProductsController.cs#L38 - Incorrect view binding (no GetProducts view exists), you should explicitly specify the name of view, like: return View("Index", productsWithDetails);
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebNetSample/Controllers/ProductsController.cs#L55 - This route is built incorrectly: whenver you start your route name with / - it will overrider base route of controller. You should start with simple word and [controller]/ route will be automatically added. So, in your case, it will look like: [HttpGet("Update/{id}")] and endpoint will be available via /Products/Update/{id}.
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebNetSample/Controllers/CategoriesController.cs#L38 - Same case above;
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebNetSample/Controllers/HomeController.cs#L2 - Unused namespaces - try to avoid them and always clean up such things. They may increase your final build and also increase time for compilation process. Update this case in your solution for all files;
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebNetSample/Middlewares/ExceptionMiddlewareExtensions.cs#L35 - it can be simplified: if (exceptionHandlerFeature?.Error is ValidationException validationException). In this case, you will not have to cast explicitly to ValidationException your errors variables and may just leave Errors = validationException.Errors here;
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebNetSample/Middlewares/ImageCachingMiddleware.cs#L13 - Not used dependency, also try to avoid such cases (in general, I see this class is not used at all, so, let's remove it then);
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebNetSample/Views/Categories/Add.cshtml#L9 - Invalid asp-controller - will not be working, please, update with Categories controller;
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebNetSample/Views/Shared/Components/CategoriesWidget/Default.cshtml#L22 - No such action exists, please, add it if it was removed;
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebNetSample/Views/Shared/Components/CategoryEditWidget/Default.cshtml#L4 - Incorrect endpoint name;
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebNetSample/Program.cs#L48 - After local app launch I have an error Cannot resolve symbol 'AddWebOptimizer'. Same case on 68 row. Please, fix this moment;
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebNetSample/Program.cs#L13 - In general, I would definitely advise to split your app configuration into several separate classes, because Program.cs is too overloaded. You may take a look into my solution here: https://github.com/dotnet-fizzyy/ASP.Net-Identity/blob/master/src/IdentityWebApi/Program.cs#L11;
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebNetSample/Program.cs#L33 - Instead of name unused argument it's better to use _ symbol;
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebNetSample/Program.cs#L39 - You can simplify it to options.Authority += "/v2.0/";
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebNetSample/Views/Users/Index.cshtml#L30 - Such actions do not exist, it will not work. I know, that this code belongs to Identity and might be autogenerated. If you 100% sure you don't need it - remove, please;
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebNetSample/Views/Shared/_HomeLayout.cshtml#L9 - Such file does not exist, unfortunately (same cases for other views). Let's remove this import;
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebNetSample/Views/Shared/Components/CategoryEditWidget/Default.cshtml#L4 - No such action exists, please, add it;
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebNetSample/Views/Shared/Components/ProductsWidget/Default.cshtml#L28 - Same case with non existing action;
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebNetSample/Middlewares/ExceptionMiddlewareExtensions.cs#L8 - Mistypo, should me Middleware*;
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebNetSample/Middlewares/ExceptionMiddlewareExtensions.cs#L28 - It's better to add modifiers for all class members explicitly, please, add private;
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebNetSample/Middlewares/ExceptionMiddlewareExtensions.cs#L30 (and 31) - duplication code, no need to repeat it here since you set it in UseExceptionHandler;
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebNetSample/Middlewares/ExceptionMiddlewareExtensions.cs#L40 - It can be simplified like: var errors = ((ValidationException)exceptionHandlerFeature).Errors;
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebNetSample/Middlewares/ImageCachingMiddleware.cs#L9 - Looks like it has never been used, no any references in code. Can we remove it?
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebNetSample/Controllers/CategoriesController.cs#L54 - It's better to add to all actions [Http(Verb)] attribute since you already started adding them, it will be better, clear and makes your code consistent;

Code issues for WebApi:

• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebAPI/Controllers/CategoriesController.cs#L31 - Missed / symbol, it breaks your XML comment not valid (IDE warning). Please, add it to make it consistent with others (it should be ///, update for the next endpoint as well);
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebAPI/Controllers/CategoriesController.cs#L62 - Mistypo in successful*;
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebAPI/Controllers/CategoriesController.cs#L21 - No sample request example and response description, description inconsistency;
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebAPI/Controllers/CategoriesController.cs#L76 - In my opinion it is absolutely redundant and can be removed. You have configured your global exception handler. In this case, you may easily throw exceptions in your Business layer and exception handler will return 400 status for specific exception types. Also, as far as I see from Business, your code will not be reproduceble, if no item exists 99% it will throw exception on Business layer;
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebAPI/Controllers/ProductsController.cs#L21 - Same issue with missing sample request description and response;
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebAPI/Controllers/ProductsController.cs#L51 - Unfortunately, this is a bad example: your RESTful and API endpoints in general should not perform and redirections, especially in ASP.Net Web API does not know anything and should not know and MVC layer. In this case, for simple create/update actions you can return just newly updated/created model (take a look at my example: https://github.com/dotnet-fizzyy/Diploma/blob/V2/WebAPI/WebAPI/Presentation/Controllers/EpicController.cs#L81). Note: for creation you should return 201 status code (created);
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebAPI/Controllers/ProductsController.cs#L85 - Same case with bad request handling;
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebAPI/Controllers/ProductsController.cs#L71 - Same case with mistypo in successful;
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebAPI/Controllers/ProductsController.cs#L111 - Whenever you want to return successful response on DELETE HTTP method, it should be 204 status code (no content);
• https://github.com/osmanaliyardim/WebNetSample/blob/dev/WebAPI/Program.cs#L15 - Make the following approach with as in WebNetMVC with splitting Program.cs into separate classes with config;

[dotnet-fizzyy]

@osmanaliyardim Please, check comments!