osmandapp / OsmAnd-iOS

OsmAnd for iOS
Other
283 stars 91 forks source link

Route calculation makes the app crash - avoid parameters #3453

Closed matteoar1 closed 7 months ago

matteoar1 commented 7 months ago

Description

Calculating a 90 km route makes the app crash. The only parameters I added are:

I also tried to change the language of the app but it didn't make difference.

Steps to reproduce

  1. In Menu → Configure profile (Boat, Driving, Walking or another one) → Navigation settings → Navigation type select select the two parameters (avoid paid roads and highways).
  2. Calculate a route
  3. wait for the app to crash.

Actual result

The app crash. I cannot use it.

https://github.com/osmandapp/OsmAnd/assets/146936781/13278b6c-b0e2-489f-b925-5228463bf00b

Expected result

I know that the app calculate the route locally but I didn't expect problems with a 90kms route! I just want calculate a route without highways!

Your Environment (required)

WARNING Crash-Logs MAY contain information you deem sensitive. Review this CAREFULLY before posting your issue!

OsmAnd Version: 4.6.6.1 (but I also tried the betas)
Android/iOS version: 17.2.1 (I'll update to 17.3.1 today)
Device model: iPhone 14 Pro
Crash-Logs: Attached

feb 21, 2024 12_32.log feb 21, 2024 12_13.log feb 21, 2024 12_25.log feb 21, 2024 12_29.log Feb 21, 2024 12_47.log

DmitryAlexei commented 7 months ago

OsmAnd TestFlight 4.7.2.1 iOS 17.2.1 Reproduced using motorbike profile with Avoid Toll roads and Avoid Motorways options enabled. No crash logs were generated profile - Motorcycle.osf.txt start - 45.55350° N, 8.94856° E finish - 45.13229° N, 9.55666° E

Feb 23, 2024 10_57.log

https://github.com/osmandapp/OsmAnd/assets/116079541/659adfc5-aaf1-4bf6-bb39-867a773e3f41

matteoar1 commented 7 months ago

OsmAnd TestFlight 4.7.2.1 iOS 17.2.1 Reproduced using motorbike profile with Avoid Toll roads and Avoid Motorways options enabled. No crash logs were generated Feb 23, 2024 10_57.log

video_2024-02-23_11-06-38.mp4

It literally crashed.

matteoar1 commented 7 months ago

I don't understand here. Are you telling me that the app doesn't crash?

matteoar1 commented 7 months ago

Can someone help me please? I paid for the app and I'm not able to use it as planned.

vshcherb commented 7 months ago

We reproduced the crash and going to fix it. Though as a quick workaround you can try different profile / parameters until we fix it.

matteoar1 commented 7 months ago

Hello, @vshcherb can you give me update? I contacted the support team but they won't give me my money back (that's absurd) nor a redeem code (absurd too) for the time I'm not able to use the app the way I want (the way I paid for!). How much time should I wait in order to see the problem fixed? Thank you.

matteoar1 commented 7 months ago

@Chumva @EugeneZmeuk @alexey-pelykh @sonora

RZR-UA commented 7 months ago

https://test.osmand.net/map/?start=45.553500,8.948560&finish=45.132290,9.556660&type=osmand&profile=motorcycle&params=motorcycle,avoid_toll,avoid_motorway,hhoff,nativerouting#10/45.3122/9.0376

No crash detected on current master branch via web map.

Need to test in the nightly iOS App.

RZR-UA commented 7 months ago
matteoar1 commented 7 months ago

I cannot do it. My app crash. I tested even with the beta but it still crash.

matteoar1 commented 7 months ago

Are you doing it with the simulator??

matteoar1 commented 7 months ago

If you do it on the actual phone it will crash the app. Even with the latest beta.

RZR-UA commented 7 months ago

If you do it on the actual phone it will crash the app. Even with the latest beta.

Yes, the screenshots made from a simulator with current master build.

Significant fix for car/moto routing was commited at Sun Feb 25 03:05:51 2024

Could you share the version and date of the latest beta you have tried?

Hopefully it should be fixed in builds after 26 Feb.

matteoar1 commented 7 months ago

I just tried right now and yes, it works for a 94km trip it works but if you change the destination for example "Piacenza" (trip long 112km!) it crashes. The app doesn't create crash log. The same problem.

mar 01, 2024 20_14.log

matteoar1 commented 7 months ago

It is just a matter of distance? It is just 110 kms... I have a one year old phone it should be able to calculate a <300km route??? I will never be able to use your app for longer trips?

vshcherb commented 7 months ago

This new routing algorithm crash I don't think it's a crash out of memory.

https://test.osmand.net/map/?start=45.553500,8.948560&finish=45.204296,9.501801&profile=motorcycle&params=motorcycle,avoid_toll,avoid_motorway,noglobalfile#10/45.3122/9.0376

Should be treated as bug

INFO: Route not found (dijkstra+recalc) 3062795 -> 3062418
INFO: No route found

/var/osmand-server/hs_err_pid913858.log

#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00007f5cf928b13f, pid=913858, tid=914442
#
# JRE version: OpenJDK Runtime Environment (17.0.10+7) (build 17.0.10+7-Ubuntu-122.04.1)
# Java VM: OpenJDK 64-Bit Server VM (17.0.10+7-Ubuntu-122.04.1, mixed mode, sharing, tiered, compressed oops, compressed class ptrs, g1 gc, linux-amd64)
# Problematic frame:
# C  [osmand-5674676799666209240.lib+0x2fb13f]  HHRoutePlanner::recalculateNetworkCluster(std::shared_ptr<HHRoutingContext> const&, NetworkDBPoint*)+0x7f
matteoar1 commented 7 months ago

This new routing algorithm crash I don't think it's a crash out of memory.

Enabling Developer plugin and using "Special Routing" is the solution. I don't know what it does, probably change the routing algorithm.

I tried to calculate the same route with the same profile (motorcycle, no tolls road, no highways)"Special routing" turned on and off.

Route 90kms With special routing on calculation took 4 seconds. (Video n°1) With special routing off calculation took 2' 30". (Video n°2)

I tried the same with a 125kms route and(No video due to file dimensions): With special routing on calculation took 9 seconds With special routing off the app crashes.

I tried the same with a 700kms route and (no video): With special routing on calculation took 10-20 seconds With special routing off the app crashes.

https://github.com/osmandapp/OsmAnd-iOS/assets/146936781/5fa52a35-fdde-4fc9-a664-8c8001b56552 https://github.com/osmandapp/OsmAnd-iOS/assets/146936781/15d8ddb7-a8cd-4057-855e-ccb755f287ed

DmitryAlexei commented 6 months ago

OsmAnd TestFlight 4.7.2.11

The issue is no more reproducible

... using motorbike profile with Avoid Toll roads and Avoid Motorways options enabled. No crash logs were generated profile - Motorcycle.osf.txt start - 45.55350° N, 8.94856° E finish - 45.13229° N, 9.55666° E

Settings Old routing New routing
matteoar1 commented 4 months ago

The issue is still here. Please reopen the case. It is not possible to calculate a 90km road with no toll road and no motorways. That's absurd.