osmandapp / OsmAnd-iOS

OsmAnd for iOS
Other
282 stars 91 forks source link

Redesign elevation graphs #3731

Open dmpr0 opened 4 months ago

dmpr0 commented 4 months ago

Description

Part of the

  1. https://github.com/osmandapp/OsmAnd-iOS/issues/3731
  2. https://github.com/osmandapp/OsmAnd-iOS/issues/3686

Android task – https://github.com/osmandapp/OsmAnd/issues/18204

ToDo

Default presentation, Figma

tigrim commented 4 months ago

Technical Plan: 1) Remove all warnings from the GpxUIHelper class. 2) Check the library version for relevance. Use the latest version of the library. 3) Verify that the new version plots the graph correctly. 4) Android uses https://github.com/PhilJay/MPAndroidChart, the implementation is similar to what we use. Examine which methods are called there.

Key code parts:

dmpr0 commented 3 weeks ago

Review

Screenshot
iOS Figma
Screenshot
Screenshot
Screenshot
dmpr0 commented 3 weeks ago

Review 2

Screenshot
iOS Figma
Screenshot
Screenshot
Screenshot
DmitryAlexei commented 3 weeks ago

Pin doesn't move on the map, when you use the Analyze on map option

https://github.com/user-attachments/assets/cc9b2390-813f-4798-b93d-ea5c76ad3762

dmpr0 commented 6 hours ago

Review 3

Screenshot
iOS Figma