Open dmpr0 opened 4 months ago
Technical Plan: 1) Remove all warnings from the GpxUIHelper class. 2) Check the library version for relevance. Use the latest version of the library. 3) Verify that the new version plots the graph correctly. 4) Android uses https://github.com/PhilJay/MPAndroidChart, the implementation is similar to what we use. Examine which methods are called there.
Key code parts:
GpxUIHelper class
@objc static public func setupGPXChart(chartView: LineChartView, yLabelsCount: Int, topOffset: CGFloat, bottomOffset: CGFloat, useGesturesAndScale: Bool)
iOS | Figma |
---|---|
[ ] X-Axis marks is missing
[ ] Try to align text on one horizontal line
[x] Display units (km
) on X-Axis only for first label i.e. 0 km
, 304
, 607
...
iOS | Figma |
---|---|
[ ] X-Axis marks is missing
[ ] Try to align text on one horizontal line
[x] Units are missing for Temperature
km
) on X-Axis only for first label i.e. 0 km
, 304
, 607
...Pin doesn't move on the map, when you use the Analyze on map option
https://github.com/user-attachments/assets/cc9b2390-813f-4798-b93d-ea5c76ad3762
iOS | Figma |
---|---|
Description
ToDo
Default presentation, Figma
[x] Move Y-axis labels to the right side
[x] Graphs should take all free space between paddings and Y-axis column
[x] Add left and right paddings
16 pt
[x] Add vertical padding
6 pt
between chart and Y-axis labels.[x] Column with Y-axis label should have dynamic width
[x] Labels should be placed below horizontal grid lines
[ ] We need to have ability to set different chart height on different screens