search

osmandapp / OsmAnd-iOS

OsmAnd for iOS
Other
270 stars 90 forks source link

[Plugin] duplicate online maps bug #3739

Closed Louis-LJ closed 2 weeks ago

Louis-LJ commented 1 month ago

hi,

National Spanish cards are duplicated x2. The national and regional directory is also duplicated.

here is the correct display of our online map repo

https://github.com/OsmAnd-Rendering/Online-Maps

Bug national and régional:

Bug national Maps duplicate x2:

Plugin: OsmAnd-Rendering plugin.osf

iPhone 11pro up to date, OsmAnd 4.7.6.3

yuriiurshuliak commented 1 month ago

The bug has been reproduced. To see it in action, download the OsmAnd-Rendering plugin.osf plugin for the app. Once installed, navigate to Menu - Map and Resources - Extra Maps - OsmAnd rendering online maps. You'll notice multiple duplicate maps for Spain in the results.

OsmAnd TestFlight 4.7.7.1

EugeneZmeuk commented 1 month ago

The same Custom plugin for Android and iOS versions has a wrong list and duplicate files for the iOS version.

Android version iOS version
image image
image image
vshcherb commented 4 weeks ago

To do: consult with @EugeneZmeuk and repeat same behavior as in Android (no duplicates)

tigrim commented 3 weeks ago

For custom plugins:

  1. The issue with duplication in the section is resolved by replacing in the collectCustomItems method: _customRegions = self.region.flattenedSubregions; with _customRegions = self.region.subregions; Testing is required.

  2. The count of sections is calculated incorrectly.

nnngrach commented 3 weeks ago

https://github.com/osmandapp/OsmAnd-iOS/pull/3775

DmitryAlexei commented 1 week ago

OsmAnd TestFlight 4.7.7.5 now works as expected - no more duplicated files