Crash while trying to change appearance of Favorites folder on iPad

[dmpr0]

How to reproduce

• Launch OsmAnd on iPad or iPad Simulator
• Open Menu – My Places
• Long tap on favorites group
• Select Change appearance on context menu
• Change one of the parameter – Tap Save

Actual result

• Crash. Xcode link xcode://organizer/crashes/downloadPoint?adamId=934850257&platformId=iOS&installPlatformId=iOS&analyticsPointId=HP6uggwR7SfUimpMAUO07&bundleId=net.osmand.maps

Reproduced on iPad

Reproduced on Simulator

``` *** Terminating app due to uncaught exception 'NSGenericException', reason: 'Your application has presented a UIAlertController () of style UIAlertControllerStyleActionSheet from UINavigationController (). The modalPresentationStyle of a UIAlertController with this style is UIModalPresentationPopover. You must provide location information for this popover through the alert controller's popoverPresentationController. You must provide either a sourceView and sourceRect or a barButtonItem. If this information is not known when you present the alert controller, you may provide it in the UIPopoverPresentationControllerDelegate method -prepareForPopoverPresentation.' *** First throw call stack: ( 0 CoreFoundation 0x000000011cf31531 __exceptionPreprocess + 242 1 libobjc.A.dylib 0x0000000115e707e8 objc_exception_throw + 48 2 UIKitCore 0x000000014a5b681e -[UIPopoverPresentationController presentationTransitionWillBegin] + 4090 3 UIKitCore 0x000000014a5c43e3 __80-[UIPresentationController _initViewHierarchyForPresentationSuperview:inWindow:]_block_invoke + 3117 4 UIKitCore 0x000000014a5c155b __56-[UIPresentationController runTransitionForCurrentState]_block_invoke.440 + 415 5 UIKitCore 0x000000014b7569f3 -[_UIAfterCACommitBlock run] + 55 6 UIKitCore 0x000000014b756ed9 -[_UIAfterCACommitQueue flush] + 189 7 UIKitCore 0x000000014b0fc2b5 _runAfterCACommitDeferredBlocks + 784 8 UIKitCore 0x000000014b0eb129 _cleanUpAfterCAFlushAndRunDeferredBlocks + 71 9 UIKitCore 0x000000014b11fedd _afterCACommitHandler + 58 10 CoreFoundation 0x000000011ce8d038 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ + 23 11 CoreFoundation 0x000000011ce879ce __CFRunLoopDoObservers + 534 12 CoreFoundation 0x000000011ce87f16 __CFRunLoopRun + 1158 13 CoreFoundation 0x000000011ce876ad CFRunLoopRunSpecific + 557 14 GraphicsServices 0x000000012981908f GSEventRunModal + 137 15 UIKitCore 0x000000014b0ecad1 -[UIApplication _run] + 972 16 UIKitCore 0x000000014b0f1551 UIApplicationMain + 123 17 OsmAnd Maps 0x0000000102fc3b30 main + 96 18 dyld 0x0000000113e103e0 start_sim + 10 19 ??? 0x000000020b7cf366 0x0 + 8782672742 ) libc++abi: terminating due to uncaught exception of type NSException ```

Expected result

• Saving without Crash

Environment OsmAnd Version: 4.8.3.0 iOS version: 17.5.1 Device model: iPad Air (5th generation)

[DmitrySvetlichny]

https://github.com/osmandapp/OsmAnd-iOS/pull/3980

[DmitrySvetlichny]

Checked potential similar crashes on the project