osmandapp / OsmAnd

OsmAnd
https://osmand.net
Other
4.37k stars 986 forks source link

Switch on rendering of access tag by default #10983

Open joostschouppe opened 3 years ago

joostschouppe commented 3 years ago

🚀 feature request

Switch on rendering of access tag by default

The Belgian OpenStreetMap chapter processes more than one complaint per month from people who say a path on their property should not be used by the general public. They generally want us to delete them. But if the path is observable, we explain that it's better to keep it on the map, and (hopefully) correctly map it as private. However, many apps don't show that info clearly on the map. As a community, we're trying to talk to app-makers to take this info in account. Osmand does a great job at showing the info, BUT the feature to show this info is a little bit hidden. The suggestion is to switch this on by default.

So the suggestion is: on new installs, activate the rendering of accesibility by default.

This is of particular interest to hikers and bikers, so perhaps the default could be associated to just those profiles. However, for cars, the information is becoming more and more relevant too, as more details are getting mapped. The number of driveways worldwide has doubled in the last year or so - and a lot of them are private. Access roads in general can provide useful shortcuts. Users might be annoyed when they are not used by the routing, showing them as private on the map might make it easier to understand routing choices. The same layer also contains toll road info, which is also always nice to know. For 4WD vehicles the info is also of particular interest.

vshcherb commented 3 years ago

I tend to disagree cause it needs to come with explanation. It's 1 story if you enable something and starts to see new dashes / strange lines and completely another if app uses it by default without proper introduction. If you want to share within specific group it's better to create profile: OpenStreetMap Belgium and share it within group with proper communication.

I would definitely agree that we need to render more icons that could explain but different types of dashes are not very explanatory .

joostschouppe commented 3 years ago

I understand your point. Though red dots on top of a path are pretty self-explanatory IMHO. To realize blue means destination and purple is with a fee, yeah that does take a little more time.

(note that it is exactly the difficulty of communicating to data users, in this case hikers and bikers, that is the difficult part. Hence why we are talking to different map developers to make it more obvious when a path isn't for general use. Different solutions are possible, like showing them only at high zoom, overlaying access icons, not showing them at all,...)

vshcherb commented 9 months ago

To do: Icons needs to be clickable (POI) image

vshcherb commented 8 months ago
xmd5a2 commented 8 months ago

Dev notes: It will not be possible to do it as needed with the current implementation of propagateToNodes. That's what I'm doing:

<type tag="osmand_access" value="private" minzoom="13"/>
<entity_convert pattern="tag_transform" from_tag="access" from_value="private"  if_tag1="highway" to_tag1="access" to_value1="private" to_tag2="osmand_access" to_value2="private" propagateToNodes="all" notosm="true"/>

It is necessary to limit the scope only to roads, otherwise a lot of problems will arise. This is apparently due to the fact that propagateToNodes is working before entity_convert. No nodes are added, just the osmand_access=private tag is added to the way: Way types [osmand_access-private (51), highway-track (15)] add_types [access-private(50),

xmd5a2 commented 7 months ago

Fixed. Icons for access restrictions were added. Luxembourg map was regenerated. Place to test изображение

DmitryAlexei commented 7 months ago

OsmAnd~ 4.6.0#1032m, released: 2023-11-15 In the latest nightly builds, access restrictions can be only enabled/disabled using Hide menu (menu > configure map > hide > access restrictions). But in the Details menu (menu > configure map > Details) you can still find Show access restrictions and toll option, that do not work anymore.

pebogufi commented 7 months ago

But in the Details menu (menu > configure map > Details) you can still find Show access restrictions and toll option, that do not work anymore.

@DmitryAlexei But now toll roads are no more visible and i can't switch it on. I can't check that with Luxembourg map because Lux does not have toll roads, as far as i know. South of it near Saint-Marie-aux-Chenes (France) is a motorroad with toll. (A4) 49.18558 6.00254 I can only see that it is toll with older version 4.0.6#1032, 2023-11-15

vshcherb commented 7 months ago

Probably we need now setting to show toll roads otherwise it's a regression

pebogufi commented 7 months ago

Probably we need now setting to show toll roads otherwise it's a regression

I would prefer setting at position as it was before, only changed name

xmd5a2 commented 7 months ago

Separate "Show toll restrictions" option was added. Toll rendering is now separated from access.

sonora commented 7 months ago

https://github.com/osmandapp/OsmAnd-resources/commit/6c1da2621ac419e9f2b156590c47601847b05ea1 may fix it for default_render, but it is still a regression for many other map styles, or am I mistaken?

xmd5a2 commented 7 months ago

@sonora this is used only for default map style. Topo and LightRS have different access visualizations.

sonora commented 7 months ago

I have just tried e.g. Touring view, and it seems the menu points Dteails>Show toll restrictions and Hide>Access restrictions are now entirely effectless?

xmd5a2 commented 7 months ago

@sonora I forgot about Touring view. Fixed now. Should work like in default style. Please check.

sonora commented 7 months ago

Yes, that would fix it, thank you! Had just not checked if we have a similar situation also in other styles, but perhaps not.

sonora commented 7 months ago

Now "Show toll restrictions" appears at the very bottom of the long Details list, should we not move it to where all the other road-related 'Show..." items are like surface, quality, LEZ? I would even put it to the beginning of that group, it seems the most significant in many countries.

EDIT: https://github.com/osmandapp/OsmAnd-resources/pull/1026 - hope that's ok.

dmpr0 commented 7 months ago

Review

xmd5a2 commented 7 months ago
dmpr0 commented 7 months ago

Review - 2

johnpercy commented 7 months ago

Toll roads seem to be permanently on for me except for low zoom in this commit. I think UniRS will also need the same treatment as Touring to get access and tolls to work again

xmd5a2 commented 7 months ago

@johnpercy I've checked UniRS and it already works as expected

xmd5a2 commented 7 months ago

@dmpr0 see https://github.com/osmandapp/OsmAnd/issues/10983#issuecomment-1805451968

ivanPyrohivskyi commented 7 months ago

New access icons will be available in the new December 2023 maps. For test need regenerate map.

dmpr0 commented 7 months ago

Review

Screenshot
vshcherb commented 6 months ago

Detection border points to place stop icons:

  1. Most complex and correct part that stop icons shouldn't be placed on the OSM node but not in the middle between OSM Way segments. For example "T"-intersection and "I" is a private road, we shouldn't place stop icon on intersection as it confusing.
  2. Correct detection border point (as OSM node): it's a point that has intersection of "private" and "non-private roads". To get it working correctly all roads need to be analyzed which is very significant performance implication.
vshcherb commented 6 months ago

This looks definitely incorrect, so it's a question whether we are ready to release this feature.

xmd5a2 commented 6 months ago

All commits were reverted