Public Holidays are not supported in OsmAnd

osmandapp / OsmAnd

OsmAnd

https://osmand.net

Other

4.63k stars 1.01k forks source link

Public Holidays are not supported in OsmAnd #11344

Open Discostu36 opened 3 years ago

Discostu36 commented 3 years ago

Description

For POIs in Germany, OsmAnd doesn't seem to know that today is Easter Monday, a public holiday. POIs with ph off are shown as open. Maybe the database for PH is incomplete.

How to reproduce?

Download maps of Germany and select a POI that has ph off in opening_hours tag.

Maps used (online or offline):
Germany_schleswig-holstein_europe.obf from March 1st 2021

vshcherb commented 3 years ago

PH is not supported at all in OsmAnd yet.

Discostu36 commented 3 years ago

Oh, I didn't know that. Maybe you can use code from https://github.com/opening-hours/opening_hours.js ?

https://github.com/opening-hours/opening_hours.js/blob/master/src/index.js contains calculation of movable holydays
https://github.com/opening-hours/opening_hours.js/tree/master/src/holidays has holidy data for many states including school holidays for some

snouup commented 3 years ago

As much as I would love this feature, the dataset you've pointed to is pretty large and besides, could be a trouble to maintain if there are changes. Maybe it's better for users to download only the data for their country, which they can add into a calendar app or set notifications.

Lee-Carre commented 2 years ago

Duplicate of #2610 ?