osmandapp / OsmAnd

OsmAnd
https://osmand.net
Other
4.6k stars 1.01k forks source link

Make colors style-independent & configure transcluency #11651

Open sonora opened 3 years ago

sonora commented 3 years ago

See the following screenshots:

Inkedlight_LI Inkeddark_LI

cepprice commented 2 years ago

The first issue is connected to https://github.com/osmandapp/OsmAnd/issues/11572 and was fixed here https://github.com/osmandapp/OsmAnd/pull/12846

vshcherb commented 2 years ago

We think to delete different possible values from rendering style in order to make consistent with width & simplify UI understanding, so color selection dialog is consistent for all rendering styles.

We still think about:

  1. How to configure translucency for designed set of colors
  2. To keep "red" exactly the same for all rendering styles or to allow small grade variations (so "red" will be stored as "red" in GPX-style).
sonora commented 2 years ago

I meanwhile managed to solve the issue about the colors being offered, it resulted from the renderer files in ressource branch r4.0 not having been synced with master in many months. I manually updated the respective color lines in both branches' xml files and the issue is solved. @vshcherb I suggest we should take no further action with regarrd to this.

This reduces this issue to simply to a mere UI problem, the hardly visible circle around the selected color and style buttons on the color dialog (particularly in dark theme), as reported in the very first post of this thread.

vshcherb commented 2 years ago

@sonora we still think to make an action, 1) we want colors to be provided by program (not by style ) - doesn't make much sense to make style-dependent 2) we need to have better to UI to configure semi-transparent colors and to have 16 colors list

sonora commented 2 years ago

But all map colors are style-defined. 😉 Why remove this flexibility for tracks?

vshcherb commented 2 years ago

Map-colors yes, but it doesn't make sense to change color when you switch map style. So you can't expect to have Blue track when you said I would like to have Red track. For map style, it happens you have different road colors because you didn't specify which color you want to have it. So only default color could be map styled

sonora commented 2 years ago

Yes, that's fine, I think: If you use the default color, it is defined by the style. If you select something specific, it can be sticky.

Regarding the "specific" selections, I suggest to use a conventionally recognized, generic pattern, the most prominent of which is the rainbow:, and offer all values both opaque and translucent.

Here is how this is implemented this in the Touring view style: (First blob is the default, then the rainbow selection starts with red - orange - yellow- green - blue - violet):

image