search

osmandapp / OsmAnd

OsmAnd
https://osmand.net
Other
4.49k stars 996 forks source link

Unnecessary announcement of junctions (tertiary / residential / road) #12774

Open speleoluc opened 2 years ago

speleoluc commented 2 years ago

With OSMAnd+ 4.0.7 under Android 8, while voice navigating a (road) bike itinerary from Castelnau street (Sainte-Dorothee, Laval, Quebec, Canada) to Chemin d'Oka (Deux-Montagnes, Quebec, Canada), I was riding on Rue du Bord-de-l'eau when at Rue de Val-Brillant (18N 589275 5041657) I was instructed to slightly turn right (without changing street); 200m futher (18N 588912 5041701), I was instructed to slightly turn left in front of the station. These instructions make little sense since they're not crossings, just curves in a road I'm following for kilometers.

The same occurs when navigating the Route Verte cycle path north of the Notre-Dame-de-la-Merci elderly home (Montreal, Quebec, Canada 18N 602636 5044699), where every curve is announced despite staying on the path.

scaidermern commented 2 years ago

Is this regular navigation or are you navigating along a GPX track?

speleoluc commented 2 years ago

Regular navigation. No GPX involved.

vshcherb commented 2 years ago

Links to places https://www.openstreetmap.org/way/294837076 https://www.openstreetmap.org/#map=19/45.54824/-73.68538

vshcherb commented 2 years ago

In first case there is a deviation here, so it's announced based on the angle - https://www.openstreetmap.org/way/45368443.

Similar issue was discussed here https://github.com/osmandapp/OsmAnd/issues/12481.

As I see now residential and tertiary roads considered to be same priority so every junction of these roads is announced (https://github.com/osmandapp/OsmAnd/blob/4361818938b96d22e1fbbfc92a9bb5cd3facd83c/OsmAnd-java/src/main/java/net/osmand/router/RouteResultPreparation.java#L1095)

Zero3 commented 2 years ago

It sounds like these turn announcements are considered at every junction with other roads. Intuitively, I think this is wrong when the route continues along the same road (where "same" means either the same OSM way or same road name) even if has a bend. But this is just my intuition, and maybe there is a good reason for the current behaviour.

pebogufi commented 2 years ago

@Zero3 see also the discussion about turn (left/right) vs. of keep (left/right) and leaving the road (where i am) vs. staying on that road in https://github.com/osmandapp/OsmAnd/issues/8329