osmandapp / OsmAnd

OsmAnd
https://osmand.net
Other
4.61k stars 1.01k forks source link

Feature request : Display line of sight #13279

Open rooart opened 2 years ago

rooart commented 2 years ago

๐Ÿš€ feature request : Display altitude and line of sight

Context

I've been trying to switch from Locus Map to OsmAnd+ for hiking. I have found many great advantages with OsmAnd including live updates, search feature, POI display, custom map rendering and so much more. But there are still 2 missing features that force me to open Locus Map during my hikes. I have the feeling that they would be quite simple and quick to implement in OsmAnd so I am suggesting them here.

Description

Illustrated Proposed solution

feature_request

vshcherb commented 2 years ago

We already have an open issue to display altitude at each point

rooart commented 2 years ago

We already have an open issue to display altitude at each point

Oops, my bad: I search for "elevation" before posting and found nothing, but you are right I can see 2 related issues for altitude display:

The need is the same: the proposed implementation is different. With the first one you need to click on the map to get the information => additional action, less fluid from where i stand but implementing both would not hurt... With the second one (coordinates widget), you still get X and Y coordinates on top of the altitude, which is more heavy on the display if you do not need them. Honestly I would prefer my proposed implementation. But anyway 3 open issues showing there is a real need for it ๐Ÿ‘

And what about line of sight ?

vshcherb commented 2 years ago

Line of sight is something new and we're wondering whether small simple triangle doesn't help enough. We're not sure whether most of the phones could provide any similar precision to have as a line.

rooart commented 2 years ago

Line of sight is something new and we're wondering whether small simple triangle doesn't help enough. We're not sure whether most of the phones could provide any similar precision to have as a line.

Line or triangles can work but from experience (looking at summits) the difficulty comes when you need to zoom in on the map at some distance from you. Meaning that the map is not centered anymore on your location, but is centered on the object you are trying to identify, and your location is out of the map. This is why you need an "infinite" display such as a line (or a line with triangles as per picture).

jandr commented 1 year ago

The proposed "line of sight" surely can be useful and interesting (although as mentioned, I am not sure how the compass and gps would be to be able to use it in practice).

However, another use for the "line of sight" which I would find interesting is if it would be possible to draw a line between two selected points on the map, and determine whether there is an unobstructed line of sight between them. My use case for this would be when planning photography sessions or when setting up antennas for communication, which require unobstructed line of sight.

Thanks!

fedcas commented 1 year ago

Line of sight is something new and we're wondering whether small simple triangle doesn't help enough. We're not sure whether most of the phones could provide any similar precision to have as a line.

Line or triangles can work but from experience (looking at summits) the difficulty comes when you need to zoom in on the map at some distance from you. Meaning that the map is not centered anymore on your location, but is centered on the object you are trying to identify, and your location is out of the map. This is why you need an "infinite" display such as a line (or a line with triangles as per picture).

I second this line of sight thing. Actually there is an app just for that, but it's buggy from my experience. Also, why install a separate app based on OSM when you could just use osmand and its offline maps? It should be really easy to implement since the compass orientation is already there.

vshcherb commented 1 year ago

Point of elevation is implemented, line of sight is not that precise as we want it, so it should be more like a sector than.

fedcas commented 1 year ago

A circular sector would be great. If you are concerned about the precision maybe a popup with a disclaimer and reminder to calibrate the compass could help.

Thanks anyway for the great work!

P.S. i forgot to link the app I was mentioning if you want an example (but it's buggy and not updated), it's called OSM peak finder

sonora commented 1 year ago

@vshcherb Question regarding

line of sight is not that precise as we want it, so it should be more like a sector than.

Why is that? Surely the device orientation is simply a discrete direction, derived from the magnetic sensors? So it's the same value we derive the "Map orientation by compass" from at rest? So we offer to display the map rotated accordingly, why could we not also offer to display that value as a line?

fedcas commented 1 year ago

Random ideas:

sonora commented 1 year ago

My point is we have no measure of compass accuracy in Android as far as I am aware. There is, certainly, inaccuracy, but it depends on e.g. when you last calibrated by twisting through all axes. I would not know how to measure and quantify the current inaccuracy, hence have no basis for what cone angle to draw.

But would advocate drawing a line, damped by Kalman filtering for usability.