osmandapp / OsmAnd

OsmAnd
https://osmand.net
Other
4.73k stars 1.03k forks source link

offline maps always updated on mobile data connections #15365

Closed twojstaryzdomu closed 2 years ago

twojstaryzdomu commented 2 years ago

Description

Offline maps get pulled on all types of internet connections indiscriminately, which will lead to charges or used internet quota on metered networks for many users. An option to avoid updates on mobile data networks is a key necessity here.

Filing this under bug due to exposure and likely financial impact or monthly data quota loss.

Downloading large offline (several hundred MBs worth of data) on mobile internet defeats the purpose users enable them for. The chief reason is usually to avoid charges or running out of monthly quota.

It can be especially problematic abroad, case in point a user that has specifically set up offline maps to avoid roaming network charges, only to find osmmap auto-download offline maps for updates. The bills for data in some regions while on roaming mobile networks abroad can be huge.

What is more, offline map updates cannot be stopped from the information pop-up on Android 12. So if a user finds their map is updating and wants to stop it, there is no way to stop the process half-way through. To stop updating, the user needs to open the app and find the right menu option, which given offline maps are not under the settings menu, can difficult. And it is a hassle to enable updates back when on wifi.

How to reproduce?

Set up offline maps updates. Use osmand irregularly to have a map becoming obsolete. Enable data connection over mobile network. Enable osmand to observe offline maps updated.

Your Environment

OsmAnd Version: 4.1.11 Android/iOS version: 12 and earlier Device model: all

Maps used (online or offline):
Not an issue specific to a particular map.

scaidermern commented 2 years ago

Is this about OsmAnd live? For each live map there is a switch to restrict updates to wifi only.

tradavyvy commented 2 years ago

I use osmand+ and my maps only update when I specificly tell osmand to update (wifi or mobile data). And that is precicely how I want it.

twojstaryzdomu commented 2 years ago

Is this about OsmAnd live? For each live map there is a switch to restrict updates to wifi only.

Well not inherently the live component, only a global download on wifi only option that would prevent unintended updates whilst on mobile data. The per-map download on wifi seems to be hidden all the way through, behind several option screens. Users will struggle to find it without guidance unless told explicitly such an option exists.

Can a global download on wifi only toggle be brought forward to make it more user-friendly? Many users will likely run into the same scenario. Most, if not all, apps with such a toggle are all-or-nothing update on wifi type, so the users will expect that and be fine with it. Per-map is nice but unexpected when looking for a simple option.

Also, it doesn't seem possible to be able to cancel an ongoing download in any way, other than hard stopping the app's background data usage. It might be another issue to fix.

sonora commented 2 years ago

It seems a bit unclear what your issue is: Maps only update when you explicitly start a download (or update) on the Download screen. And each ongoing download has an (X) button there, where you can cancel it any time?

1

And you can always get to the download screen when you tap the download notification on the Android system notification:

Untitled

twojstaryzdomu commented 2 years ago

And each ongoing download has an (X) button there, where you can cancel it any time?

I was hoping to find it in the android pop-up. Some pop-ups do have buttons. Don't recall seeing it in the live update section.

vshcherb commented 2 years ago

There is a setting to update or not update OsmAnd Live using Mobile connection

vshcherb commented 2 years ago

I'm afraind I misunderstood the issue if it's about warning that you are about to download on mobile data, I think it's a duplicate issue

twojstaryzdomu commented 2 years ago

Of which is this a duplicate? My concern is for there not being a global option to disable all mobile downloads quickly. With many maps, it is a chore to have to toggle them back and forth as needed.

vshcherb commented 2 years ago

Yes there is no such thing unfortunately, I believe it should be implemented on Android level

scaidermern commented 2 years ago

With many maps, it is a chore to have to toggle them back and forth as needed.

Why do you need to change this setting so often? Either you want map updates on mobile data or you don't want them.

twojstaryzdomu commented 2 years ago

Why do you need to change this setting so often? Either you want map updates on mobile data or you don't want them.

Simple. Border crossing case, no desire to pay for large map downloads while abroad WITHOUT having to:

  1. Toggle updates several maps on and off every time I am on roaming data network abroad.
  2. Disable data altogether merely to prevent maps from being updated. At the same time, email will work while on a roaming data network.

People can cross borders often so the setting matter. I'm sure you can think of other use cases for a global switch.

Discretionary per-map update switches are overkill. Also, most other apps that allow updates of a component feature a single global mobile data off switch. It doesn't need to be as fine-grained.

sonora commented 2 years ago

You can prevent apps from background-using data in (Android-)Settings/Apps/Osmand/Allow background data usage.

twojstaryzdomu commented 2 years ago

You can prevebt apps from background-using data in (Android-)Settings/Apps/Osmand/Allow background data usage.

It's not about stopping data in the background only. The updates will still run when osmand is in the foreground so it's not changing anything.

The bug here is about the inability to disable all updates globally within the app via a single switch, like in most of other ordinary apps with updates.

Can this bug be reopened?

sonora commented 2 years ago

This issue initially sounded like there is some bug with all offline maps updating automatically and uncontrollably, but from what I see now there is nothing left here that is not already in #13856.

twojstaryzdomu commented 2 years ago

I see now there is nothing left here that is not already in #13856.

Where? I don't see anything related to a global mobile data usage killswitch for updates. Besides, that bug is a 'nice to have', i.e. a nicer way of saying 'won't fix'. I can reword this bug specifically for the sake of users who travel across their national borders and are often subject to roaming data charges but would like it opened back, not dismessed under a catch-all request relating to mobile data.