osmandapp / OsmAnd

OsmAnd
https://osmand.net
Other
4.67k stars 1.02k forks source link

OpenGL puts text over hillshade vs v1 (text shadow becomes more prominent) #16234

Open sonora opened 1 year ago

sonora commented 1 year ago

Is it on purpose or an oversight that OpenGL seems to use a lot more text shadow where Version 1 rendering does not, e.g. for village names, mountain captions, mountain ranges. Observed both in default render as well as dependent map styles like Touring view. See here V1 on the left, v2 on the right:

Screenshot_20230114-090537_OsmAnd~ Screenshot_20230114-090524_OsmAnd~

Screenshot_20230114-090319_OsmAnd~ Screenshot_20230114-090302_OsmAnd~

pebogufi commented 1 year ago

V1 is better readable, see also altitude in contour lines.

sonora commented 1 year ago

PS: It appears that not just text labels use the shadow but even icons, like the mountain top icon?

Screenshot_20230114-092935_OsmAnd~

arncor commented 1 year ago

I noticed that too, I prefer the v1 looks too ;)

sonora commented 1 year ago

Yes, I prefer V1, too, it should always be our benchmark as it's been tested and tweaked over many years.

PS: And please don't use my screenshots above for the final quality assessment, I have reduced the size of the screenshots to fit them better in this post, they are not the original resolution and hence artificially blurred.

vshcherb commented 1 year ago

Comparing opengl / v1 don't see much difference

sonora commented 1 year ago

Here are partial screenshots in my original screen resolution (there are some slight jpg artifacts by cutting):

Look village label "Castelluccio" and the mountain peak label "Monte Veletta (1614)" to spot the difference: 1 2

While above it seems we simply use regular letters in V1 and cased letters in V2, also, look at the road casing here: Doesn't it look somehow blurred and hence thicker and darker in the bottom (V2) case? (But other tha ncased vs. uncased letters above, this second observation may just be how OpenGL handles pixelation, so this may not be anything to fix.): 3 4

EDIT: loc is https://www.openstreetmap.org/node/385616647, maybe it helps if you produce corresponding screenshots?

vshcherb commented 1 year ago

I think I've got what's going on... The problem that v1 puts hillshade on top of the text and it looks less prominent but v2 does it other way around, in some sense it's a matter of taste but this one of the issue which we couldn't fix or choose in v1 or v2, so far. So we even make special setting for Overlay setting to have it half-transparent

sonora commented 1 year ago

Yes, that explains it, Victor! I was wondering why also in v1 there seems to be a very faint letter casing if you look vvery close, and what you state sounds like the answer.

Cannot say what a proper fix ccould be and how complex it would be. Sounds like there are opinions that the v1 appearance is superior, but that could also be a matter of what we have become used to.

Zirochkabila commented 1 year ago

OsmAnd~ 4.4.0#14172mqta, Released: 2023-02-12 Indeed, with V2 rendering, the text is more visible and clearer than with V1 rendering. But, as Victor explained above, this is how OpenGL works. And, yes, it's most likely a matter of taste - I prefer the picture with V2 rendering (if we're talking about a specific example) - text looks lighter, which in turn is easier to perceive.