osmandapp / OsmAnd

OsmAnd
https://osmand.net
Other
4.67k stars 1.02k forks source link

Add Markers tab to My places menu #16513

Open Velomeloman opened 1 year ago

Velomeloman commented 1 year ago

🚀 feature request

Description

Markers are not so often usable feature (for me) and I hide it from Drawer to save space. But if I need it, there is no other way to open Markers screen.

Describe the solution you'd like

Please add Markers tab to My places menu. It's logically correct in my opinion.

IMG_20230221_142648_156.jpg

ceever commented 1 year ago

Oppose.

I don't know whether adding this feature is such a good idea. The list of markers is readily available at the top of the map, that is their purpose. Moving it to My Places duplicates functionality and error/inconsistency potential. Or moving it out of the main all together will break the behaviour for many other uses except for you—that's inproportionate.

It's your deliberate decision to not have it display. But the non-display is mostly intended for people that do not use the marker feature altogether. You always have the option to use favourites instead, but you don't. I mean come on, this sounds like the app is working properly, but you just don't want to use it in the way it is intended to be used.

Hence, I don't see any need for wasting valuable resources on such an incoherent idea. Sorry 🤷

sonora commented 1 year ago

@vshcherb In principle, I have sympathies with what @ceever outlines.

Basically because I have always had reservations about the separate 'Map markers' concept: There is quite a significant overlap with 'Favorites' base functionality, which may not justify the entirely separate 'Map markers' look and feel, and implementation we have. Now assimilating both Map markers and Favorites functionalities further but on parallel tabs or screens may aggravate the issue.

I have not thought it through, but have a gut feling that combining 'Map markers' into the current 'Favorites' approach and code as something like a special group ("temp favs") may be the way to go. For that add 1 or 2 extra features for that grpoup like e.g keeping our separate 'Set as marker' button to quickly add to it directly with no interim dialogs.

Would also reduce our code base and save corresponding maintenance effort. E.g. also all import/export/backup modalities devs work so much on would collapse with that for favorites where we use separate gpx files per fav group in our data structure anyway now.

ceever commented 1 year ago

I also have a little headache with the simultaneous favourite and marker concept. Simplification is always a good idea. 👍

Velomeloman commented 1 year ago

@ceever, I always use favourites instead) And I didn't offer to MOVE Markers from Drawer, just add tab. Favorites, Tracks and OSM Edits can be added to Drawer. Some actions in Drawer like Configure map and Navigation duplicated by buttons on main screen. That is not problem to duplicate actions by customization of interface. This issue was created not for my personal needs. I partially agree with @sonora about combining Markers and Favorites. But as said @ceever that will break the behaviour for many people. So I offer simple solution, that seemed logical to me.

vshcherb commented 1 year ago

Markers refactoring has always being postponed cause it won't make it simpler. We simply need to split 2 concepts: quick add/edit bookmark for a place and 2nd is a direction widget to a point (to have an itinerary list sorted and visible).

Even though there were preparation done but they are not finished cause it will change situation and introduce another concept however it will make them simpler.

mariush444 commented 2 months ago

Less options in 1st menu level then better in my opinion. Additionally, why to have hide and details separate manu for boolean values in rendering? Why to have chackboxes and switches in separate menu? Hide menu with "hide water". Just option in details "hide water" seems to be enough.