osmandapp / OsmAnd

OsmAnd
https://osmand.net
Other
4.58k stars 1.01k forks source link

Unexpectedly Straight -> TSLL and TR -> C #16752

Closed razor74 closed 1 year ago

razor74 commented 1 year ago

Description

When i drive in the direction from screenshots below, a wrong turn lane count( arrows) is show on the top of the screen - 5 lanes , but the real lane count is 3. You can see the exact location where i was and in other screenshot the turn lane schematics from JOSM.

Steps to reproduce

When i drive from Soseaua Vitan Barzesti road to Soseaua Oltenitei road.

Actual result

5 turn lanes

Expected result

only 3 turn lanes

Your Environment

OsmAnd Version: Osmand+ Pro 4.4.3 Android/iOS version: Android 13 Device model: Xiaomi Mi11

incorrect lane count

Zirochkabila commented 1 year ago

@razor74 What maps of this territory and country do you have downloaded, do you use live updates?

razor74 commented 1 year ago

I have Romania map from 1 march 2023 and i use live updates.

Zirochkabila commented 1 year ago

OsmAnd 4.4.4, released: 2023-03-22

1

Moved to https://github.com/osmandapp/OsmAnd/issues/16279

2

Moved to https://github.com/osmandapp/OsmAnd/issues/13829


3

53.90069, 27.61206 Map OSM OsmAnd

https://user-images.githubusercontent.com/104760013/227518041-2a5bc378-9262-49a2-9795-6552613f680d.mp4

razor74 commented 1 year ago

Osmand still shows wrong lane count. This is the real turn lane configuration. Nowhere are 5 lanes per direction. Just before the segment where now it shows correct lane nr. it shows 5 lanes, but there are only 4. image

SamRuzhowski commented 1 year ago

OsmAnd 4.4.4, released: 2023-03-22

44.386406, 26.139163 Map OSM OsmAnd

Same 53.884649, 27.619833 Map OSM Osmand

53.90069, 27.61206 Map OSM OsmAnd

And Уральская street from 3rd video at the end has turn:lanes:backward=reverse;left|through;left|right. Way 868135783. So lanes need to be like this. Screenshot_20230325-112446_1_1

vshcherb commented 1 year ago

To do: No 1 (left|through|through|right and instead we see only C|C|C|C|C), No 2 - should be fixed. No 3 - not reproduced.

razor74 commented 1 year ago

Hi. the problem is present on map release from may. The map show now 6 lanes instead of 3.

vshcherb commented 1 year ago

TODO

1

Through (Straight) turn indicator is replaced turn slightly left.


2

44.386406, 26.139163 Map OSM OsmAnd

https://user-images.githubusercontent.com/104760013/227515365-42186839-af21-498d-8143-16864930f1fe.mp4

ivanPyrohivskyi commented 1 year ago

PR https://github.com/osmandapp/OsmAnd/pull/17421 Test case 53.884649, 27.619833, before/after. OsmAnd do not show left turn and reverse at same time (in UI), but code instruction is consist reverse (TU) 34233649 Go ahead (+TL,TU|+TL,C|TR):

ivanPyrohivskyi commented 1 year ago

1

Test case 44.386406, 26.139163 after PR https://github.com/osmandapp/OsmAnd/pull/17421 Before/after Lanes configuration of intersection are right, but this way to fuel station also counting as possible lane. I suggest to avoid all service=* roads (but not all highway=service) in lane counting. (Is wrong, see place 35.83824, -78.64158) Will be in separate pull request.

After data fix:

ivanPyrohivskyi commented 1 year ago

2

Test case 50.24268, 18.9957 Need to fix data. Way 234238770 (through|through|through;right) is not connected with way 128275340, therefore OsmAnd generate syntetic lanes instruction.

Before/after fix data:

JOSM: Screenshot 2023-06-15 at 11 56 54

ivanPyrohivskyi commented 1 year ago

3

Test case 49.57615, 11.0159 (test "21.Äußere Nürnberger Straße C" with new data is ignore=true in PR) Need to fix data or create virtual syntetic lanes for way 430007222 like TL|C or TL|TL|C|C (from way 515591061). Ways with lanes: Way 30405356 left|left|through|through|right|right that use for instruction. Way 515591061 left|left|through|through

Present restriction only_straight_on

vshcherb commented 1 year ago

Summary Jun 16 2023

All mentioned cases are fixed except 3

vshcherb commented 1 year ago

Slightly different fix for a topic starter that we've udpated the map https://www.openstreetmap.org/changeset/137612121 cause service roads could be counted in turn:lanes - https://www.openstreetmap.org/way/693970262

xmd5a2 commented 1 year ago

Test for https://github.com/osmandapp/OsmAnd/issues/16752#issuecomment-1592678308 added https://github.com/osmandapp/OsmAnd-resources/commit/054f6600b63908527263f4e4666d9a90167b466b