search

osmandapp / OsmAnd

OsmAnd
https://osmand.net
Other
4.66k stars 1.02k forks source link

My Places > Tracks: Sorting order gets lost #17475

Closed scaidermern closed 1 year ago

scaidermern commented 1 year ago

OsmAnd 4.5.3

Steps to reproduce:

☹️

zipav commented 1 year ago

OsmAnd 4.5.3, released: 2023-06-20 OsmAnd Nightly 4.5.0#284m, released: 2023-06-23

Steps to reproduce

https://github.com/osmandapp/OsmAnd/assets/123936521/f79bf6fa-1b4f-4173-98e2-38eeff985070

https://github.com/osmandapp/OsmAnd/assets/123936521/57448652-b7a3-4617-8e8f-8fe86eb63133

scaidermern commented 1 year ago

Another way to reproduce this:

yuriiurshuliak commented 1 year ago

We were unable to reproduce the bug you mentioned, after selecting the sort and opening the track, the sort remains the one we selected. We tested the two methods you mentioned. Please try the latest nightly version or beta version.

OsmAnd~ 4.5.0#313m, released: 2023-06-29 OsmAnd 4.5.3, released: 2023-06-20

Reproducing on Beta Reproducing on Nightly Reproducing the alternate path of the bug, Nightly version
scaidermern commented 1 year ago

Another way to reproduce this:

* Go to My Places / Tracks / Visible on map

* Change something, hit apply

* Sorting order at My Places is reset to Last modified

Still reproducible with the new version 4.5.4.

https://github.com/osmandapp/OsmAnd/assets/1040784/191d9f58-b5ea-418a-abdf-b1d814e1c7e5

Please reopen.

sonora commented 1 year ago

I think it's a new regression, had meanwhile been fixed. Likely one of the things which would be complete non- issues if we followed this idea: #17538.

DmitryAlexei commented 1 year ago

Cannot reproduce with different combinations of tracks and sorting options in both folders (entire tracks folder and visible on map folder) OsmAnd~ 4.5.0#344m, released: 2023-07-05

yuriiurshuliak commented 1 year ago

I reproduced this bug in different variations:

Everything was done according to the user's instructions, unfortunately, the reproduction of this bug was unsuccessful. Please confirm if this issue is reproduced in the latest nightly version? It would also help us in further investigation if you could provide your logcat files.

OsmAnd~ 4.5.0#351m, released: 2023-07-06

scaidermern commented 1 year ago

Please confirm if this issue is reproduced in the latest nightly version?

I can't reproduce it with nightly 4.5.0#351m. Looks like it has finally been fixed.

scaidermern commented 1 year ago

Nope, it hasn't. But maybe I found the difference between your and my tries to reproduce this.

This does not reproduce it:

This does reproduce it:

So it looks like the sorting order of the directory of the track that is changed is copied to the top level directory?

yuriiurshuliak commented 1 year ago

After following your updated instructions on the new nightly version, we made an attempt to replicate the error, but were unsuccessful in reproducing the problem.

OsmAnd~ 4.5.0#367m, released: 2023-07-10

https://github.com/osmandapp/OsmAnd/assets/127092082/ec848670-ffef-49ba-9414-1b6764e40d7a

scaidermern commented 1 year ago

@yuriiurshuliak That's not quite what I wrote. What you are missing is the part "A track that is located in a sub directory (where sorting order is set to Last modified) is made visible (or invisible)".

You are opening a track sub directory ("Rec") that is set to Last modified. But you aren't changing the visibility of any of the tracks that are located in this directory.

So please try to change the visibility of one track inside the "Rec" directory. Then check if the sorting order of the top level directory is still set to "A-Z".

yuriiurshuliak commented 1 year ago

I tried to reproduce the bug with your comments. Sorting has been enabled as you requested. First, variable actions were performed in the first folder, then in the second folder. No result was achieved. Please, attach a video, of how you reproduce it step by step from your side.

OsmAnd~ 4.5.0#373m, released: 2023-07-11

https://github.com/osmandapp/OsmAnd/assets/127092082/08c0c497-3491-4f64-9640-30a5f8f80a78

scaidermern commented 1 year ago

Please, attach a video, of how you reproduce it step by step from your side.

I already did that here: https://github.com/osmandapp/OsmAnd/issues/17475#issuecomment-1622977126

This works in both version 4.5.3 and the nightly 4.5.0#351m. I have no idea which other conditions have to be met. Maybe a developer should take a closer look at the corresponding code to check which actions can lead to a change of the sorting order. Can't be too hard.

Rowin63 commented 1 year ago

On every crash, sorting is set back to "last edited". And I don't even get and never had all my 50 folders set to "A-Z", because just scrolling the folders and doing this setting one by one crashes Osmand, and back I am to "last edited".

EDIT: finally I got all tabs set to A-Z. It never was possible because of the crashes. But doing it in three runs (and exiting the app in between, every time noticing it getting slower) it was possible. And the setting remains even after a later crashing.

Rowin63 commented 1 year ago

I just did the update to +4.5.8 and by this all track folders are set back to "last edited". So I set them back to "A-Z" one by one. After finishing this, Osmand crashed, and all was set back to "last edited" again.

exception (3).log

So I went (via "configure map / tracks) through 52 folders and set them once again to "A-Z". But in the "my places / tracks" the sorting still remains "last edited"...

And it's the same in the 4.6.0#508m. The sorting set in "configure map / tracks" does not apply to "my places /tracks".

scaidermern commented 1 year ago

I just did the update to +4.5.8 and by this all track folders are set back to "last edited".

Same for me with version 4.5.7. All previous sorting order settings lost, all back to last edited.

But it looks like my original bug is finally resolved. The sorting order is no longer reset when changing the track visibility.

scaidermern commented 1 year ago

So I went (via "configure map / tracks) through 52 folders and set them once again to "A-Z". But in the "my places / tracks" the sorting still remains "last edited"...

Can confirm. Looks like both have a separate configuration. Worth a separate ticket I guess.

Rowin63 commented 1 year ago

Creating new folders, their sorting is "last edited". So this seems to be the standard setting (personal opinion, I would prefere A-Z as standard). But also editing an existing folder changes it's sorting back to "last edited". At least, now it's the same in both menus :-) (+4.5.10)

sonora commented 1 year ago

See https://github.com/osmandapp/OsmAnd/issues/17886, I think that would save a lot of headache, and make everyday usage a lot easier (at least for me).

scaidermern commented 1 year ago

Implementing #17467 and having a default sorting order would also help a lot.

scaidermern commented 1 year ago

From time to time the sorting order still gets reset to last modified. No idea how to reproduce yet. OsmAnd 4.5.10.

sonora commented 1 year ago

Same for me. Perhaps this commit https://github.com/osmandapp/OsmAnd/commit/c856ce8e3917da66849da48fbd23d9f61f4945f2 caused it when updating to the corresponding app version. Then it should have been a one-time effect - let's watch.

scaidermern commented 1 year ago

It definitely happened after upgrading. But it also happened again afterwards, at least two times. I guess it has something to do with moving of tracks or something similar.

Rowin63 commented 1 year ago

Also here. Happens everynow and then, back to "last edited". Can't reproduce it.

scaidermern commented 1 year ago

Found out how to reproduce it, pretty easy: Change the visibility of the currently recording track (no active recording required): https://github.com/osmandapp/OsmAnd/assets/1040784/9d692b20-fb7d-4792-bacf-9925f646fb9f

OsmAnd 4.5.10.

Please reopen.

vshcherb commented 1 year ago

Issue needs to be new open - 4.5 is closed