osmandapp / OsmAnd

OsmAnd
https://osmand.net
Other
4.58k stars 1k forks source link

Hungarian - Voice prompts #17479

Closed d4f5409d closed 2 months ago

d4f5409d commented 1 year ago

Description

This is a list where I collect the voice navigation issues in the hu language. I tested the voice navigation both in action and in developer mode.

Connected issues: #17478

3.7, 3.8, 3.9 and 3.10 are missing "kijárat" from the end which is the hungarian word for exit. In the sentence wit should look like "kijáraton". Note that 3.11 and 3.12 also missing this word, but we can't do much about that because it is a non TTS version so it can't tell about the custom exit the user.

5.2 : Just a little note, it would sound better to say "hajts ki az x. kijáraton" instead of the current order of the words in the sentence.

5.3: Exit is again missing "hajts ki a második (2.) kijáraton"

6.1: would sound better: "fordulj vissza x méter múlva" instead of the current one because it means the same and it is shorter. --> I noticed an inconsistency between 6.1 and 6.2, 6.3; in 6.2 and 6.3 it's great.

6.4: I would put "lehetséges" to the end of the sentence instead of current "lehet", it sounds better.

I had this much time currently, I will update this issue with more stuff as soon as I can. Stay tuned!

Your Environment

OsmAnd Version: 4.4.7 Android/iOS version: 13.1 Device model: OnePlus 8

sonora commented 1 year ago

@d4f5409d Please specify if you are evaluating the hu or the hu-formal voice. And if you let me know when you are done updating this issue, please state here, and I can take a look as I find time, perhaps provide a trial file for you to test.

Alternatively, please download the corresponding config file https://github.com/osmandapp/OsmAnd-resources/blob/master/voice/hu/hu_tts.js or https://github.com/osmandapp/OsmAnd-resources/blob/master/voice/hu-formal/hu-formal_tts.js, make your edits, and replace the existing file on your device to test. Once you are satisfied, either let me know here, or even better produce a pull request for the file you changed.

d4f5409d commented 1 year ago

Oh boy, there are huge I meam HUGE problems with this. The navigation misses so much regarding voices. Sometimes it just forgets to say what turn is ahead. This definitely needs further investigation.

I'll check up on this tomorrow when I'm at my PC.

d4f5409d commented 1 year ago

Okay, I'm browsing the files you mentioned, and I have to repeat, there's a problem with the pre-recorded voices, rather than the TTS. The TTS works perfectly every time. But since I am degoogled, I can't use TTS (because there aren't FOSS TTS engines that support the Hungarian language). I am using the hu version (and not the formal).

sonora commented 1 year ago

Regarding

The TTS works perfectly every time. But since I am degoogled, I can't use TTS

According zo https://accessibleandroid.com/list-of-languages-with-available-tts-engines-on-android/, there should be quite a few options for Hungarian TTS support?

d4f5409d commented 1 year ago

Regarding

The TTS works perfectly every time. But since I am degoogled, I can't use TTS

According zo https://accessibleandroid.com/list-of-languages-with-available-tts-engines-on-android/, there should be quite a few options for Hungarian TTS support?

Thank you for helping me (it's unrelated to the issue), but pretty much from all of it is espeak usable, but it sounds terribly.

sonora commented 1 year ago

Have you downloaded a good Hungarian voice for it? This psge here sounds like Hungarian should be past experimental: https://espeak.sourceforge.net/languages.html

d4f5409d commented 1 year ago

I checked 2, but I am sure all of them suck. But let's keep this issue tracking on topic.

sonora commented 1 year ago

Not sure I can help much with recotded voices: The configuration work is much the same we have to do for TTS. And in the end we likely need to create new recordings. So if you have a pull request, welcome to post it. If you have specific questions, leg me know, I will gladly assist.

d4f5409d commented 1 year ago

I am only a user with barely any coding knowledge :/ however thanks for the assist

sonora commented 1 year ago

I have tested a few of the examples you state above, and they seem to sound like they should, e.g. (5.3) sounds like "hajts ki a második kijáraton".

Which version of OsmAnd are you using? And please delete the hu voice and re-download it to make sure you have the latest version of the recorded voice.

If the issue is still around, can you specify for a few test buttons exactly what you hear vs. what you expect to hear? I can try to work on statements one by one, but need to be sure exactly about the to-be vs as-is.

d4f5409d commented 1 year ago

I have tested a few of the examples you state above, and they seem to sound like they should, e.g. (5.3) sounds like "hajts ki a második kijáraton".

Which version of OsmAnd are you using? And please delete the hu voice and re-download it to make sure you have the latest version of the recorded voice.

If the issue is still around, can you specify for a few test buttons exactly what you hear vs. what you expect to hear? I can try to work on statements one by one, but need to be sure exactly about the to-be vs as-is.

I am using 4.4.7 OsmAnd~ and this issue persist since I started using OsmAnd years ago. Now it's getting really frustrating. I will reinstall the voices and will give another shot to a test. If it still persist, I could provide logcat logs in a secure manner (PGP) if it is okay for you.

sonora commented 1 year ago

Please download the latest "hu" recorded vice (In OsmAnd: Menu button > Download maps > All Downloads, then near the bottom of the list "Voice prompts (Recorded)" ) - I had made an update to all recorded voices about 6 months back, I remember there were issues with e.g. the "exit" portion.

For whatever is still present then, I think we should go through some selected test buttons, and you simply write what you hear, and what you would like to hear. And wherever it involves the same vocabulary (which is already recorded), I may be able to fix it with your help and with limited effort. 😉

sonora commented 2 months ago

Let me close this as deprecated. For new findings we should open a new issue please.