osmandapp / OsmAnd

OsmAnd
https://osmand.net
Other
4.67k stars 1.02k forks source link

Voice navigation - Hungarian - Incorrect numbers #17645

Open Yogurt4 opened 1 year ago

Yogurt4 commented 1 year ago

Description

The voice navigation generates incorrect numbers between 21 and 29.

How to reproduce

Navigate anything so that the next turn will be in 21...29 kms.

Actual result

It says "húsz [silence] kettő", e.g., simply concatenating the words for 20 and 2, like if one said "ten ... three" instead of thirteen in English.

Expected result

21 = "huszonegy", 22 = "huszonkettő", etc.

Environment

OsmAnd Version: 4.4.7 Android/iOS version: 101.191014.001 Device model: Xiaomi Redmi 8

sonora commented 1 year ago

@Yogurt4 We offer 4 Hungarian voices. Which ones are affected?

Yogurt4 commented 1 year ago

I have only the following voice navigation packs available: "angol (brit)"- British English, "magyar" - Hungarian.

Of which I have the Hungarian selected with the pre-recorded option. What I hear is a youngish female voice.

The Map Download panel has two options, "magyar" and "magyar (magázó)" - both of them are green. I cannot select any other Hungarian voice packs.

sonora commented 1 year ago

I believe you should not have to fall back to using a pre-recorded voice for Hungarian in the first place. Please check your device's (not OsmAnd) settings under Language and keyboard >Text-to-speech, or similar. Pick/activate any available TTS engine, and in its settings find "Install voice data" for Hungarian, unless already present on your device anyway. Set as default, and in OsmAnd use theHungarian TTS or Hungarian (formal) TTS voice. TTS should get the numbers correct automagically.

The root issue is we currently have no recorded voice files with the correct wording for the Hungaroan numbers 21 to 29. Prerecorded voices can only replay recorded words, that's why they also cannot pronounce e.g. street or place names. They are considered a basic fallback for more exotic languages only.

PS: Can the missing numbers as crorectly spoken be concatenated from "twenty" and the single digits, like "twenty"-"and"-"three"? Tten we could copy a solution applied in the German config file. Still wondering if it's worth it, though.

Yogurt4 commented 1 year ago

Thank you for directing me to TTS. I'll try it. The reason I'm using pre-recorded because 1. it was the default setting, 2. it's the first option on the UI suggesting it's better, 3. I thought all missing words can/will be generated by TTS, as the UI has an active "Street names (TTS)" switch even when using pre-recorded voice.

Re PS: No, we have a different prefix for numbers 21...29. Just like our numbers 11...19 don't start with "ten" or "ten" + "and". But they all have their own recorded voices due to the logic of English/German, etc. languages, I presume.

sonora commented 1 year ago

Ok, thanks! Please let me know your experience with TTS, should hopefully be significantly superior.

Also: If we missed somewhere that TTS is both the more powerful and preferred option, and/or fail to place things in the right order on some screens, maybe you could assist fixing that by opening an new issue with the respective screenshots - many thanks!!