search

osmandapp / OsmAnd

OsmAnd
https://osmand.net
Other
4.61k stars 1.01k forks source link

nature of seabed "shells" not rendered #17827

Closed quantenschaum closed 1 year ago

quantenschaum commented 1 year ago

Description

polygons tagged with

are not rendered (with nautical map style). Mud (M) and sand (S) are shown as expected.

How to reproduce

Look at https://map.openseamap.org/?zoom=15.5&lon=6.17412&lat=53.45810 (need to enable live updates due recent changes)

Actual result

no shells (Sh) on the map

Expected result

blue italic "Sh" on the map, when tapped showing the outline of the polygon

Environment OsmAnd Version: 4.5.9 Android version: 13 Device model: Nokia X20

quantenschaum commented 1 year ago

In nautical.render.xml there is

<!-- <apply_if additional="seamark:seabed_area:surface=shells" shader="seamark_j11_shells"/> omitted-->

Why is it "omitted"?

xmd5a2 commented 1 year ago

Fixed изображение Netherland - Friesland map will be regenerated in 1-2 hours

quantenschaum commented 1 year ago

Is this really fixed? How are shells rendered when these lines in nautical.render.xml are commented out?

DmitryAlexei commented 1 year ago

OsmAnd~ 4.6.0#698m, released: 2023-08-30

  1. Polygon tagged seamark:seabed_area:surface=mud (https://www.openstreetmap.org/way/1195214471) is rendered according to our Map legend. You can see small transparent ovals of different sizes as an underlay and M (mud) inscription.
  1. Polygons tagged seamark:seabed_area:surface=shells (https://www.openstreetmap.org/way/1195214472 and https://www.openstreetmap.org/way/1195263187) are not rendered according to Map legend. It should be marked with Sh (shells) inscription.
quantenschaum commented 1 year ago

So, this should be reopened.

How did @xmd5a2 get the shells to show up on the map in https://github.com/osmandapp/OsmAnd/issues/17827#issuecomment-1695714620 ?