osmandapp / OsmAnd

OsmAnd
https://osmand.net
Other
4.58k stars 1k forks source link

OsmAnd could suggest that not all POI require a name and for some it suggested not to specify #18651

Open matkoniecz opened 9 months ago

matkoniecz commented 9 months ago

Description

People editing with OsmAnd very often add bogus descriptive names such as

name=Bunker military=bunker

name=Waterfall waterway=waterfall

name=Cairn man_made=cairn

name=Potable water amenity=drinking_water

name=Viewpoint tourism=viewpoint

OsmAnd edits account only for tiny part of all edits but for very large part of clearly invalid descriptive names. I have not prepared some deep statistics, so far this is based on sampling and review made when preparing bot edit. (hopefully deep analysis is not going to be needed to convince you to look into improving interface)

See also https://community.openstreetmap.org/t/is-name-toilet-even-theorethically-valid-for-amenity-toilets/105540 and https://community.openstreetmap.org/t/automatically-remove-obvious-descriptive-names-for-viewpoints-obvious-cases-only-not-all-suspect-objects/105892 and https://lists.openstreetmap.org/pipermail/talk/2023-November/088450.html

It seems to be caused by interface of Osmand editing plugin.

Current situation requires repeated and time-consuming cleanup of bad data. OsmAnd edits are still appreciated, but it would be much nicer if they would not be very often requiring cleanup.

Steps to reproduce

Follow https://www.osmand.net/docs/user/plugins/osm-editing/

Actual result

Interface does encourage to fill bogus names like name: bench for all benches

Expected result

I have some proposals to improve data quality, there is probably no need to apply all:

Your Environment (required)

OsmAnd Version: 4.5.10 Android/iOS version: Android 11 Device model: Xiaomi Lite A2 (yes, sadly)

mariush444 commented 9 months ago

the question is how to do it so as not to scare novices. It is good to take care of data quality but in places where OSM data is poor, every piece of information is worth

matkoniecz commented 9 months ago

Modifying screen12 so that name field is in attributes, not presented as main obligatory attribute would not scare novices, right?

dmpr0 commented 8 months ago

You can add bench POI without adding a name, OsmAnd doesn't require to enter name for POI.

matkoniecz commented 8 months ago

You can add bench POI without adding a name, OsmAnd doesn't require to enter name for POI.

I know.

The problem is that OsmAnd is not making it clear to less experienced people.

And OsmAnd mappers are responsible for very large amount of bogus names. Because it looks like required for many people.

vshcherb commented 8 months ago

Well good question is then to clarify what needs name and what's not. Name is not that simple tag cause for different objects it means different. Will it be better to redirect for a help with a first user edit? What could be the best scenario to help add

  1. First bunker
  2. First bench
  3. First restaurant

Obviously first editing need to be tailored but I don't think you will make same mistake if you learn a bit later

matkoniecz commented 8 months ago

Well good question is then to clarify what needs name and what's not.

only objects which have own given name, not all of them

current interface looks like name should be filled for every single object, what confuses mappers

matkoniecz commented 8 months ago

https://www.openstreetmap.org/changeset/145368855 is an example of a typical edit where some or all added names are descriptions of feature type, not an actual names

this kind of mistakes is a typical mapping error caused by bad osmand plugin interface and I found it while cleaning bad edits (note that I only removed name=Viewpoint "name" and not checked remaining ones but they look quite suspect)

DmitryAlexei commented 6 months ago

The issue has been reproduced. OsmAnd~ 4.7.0#1623m, released: 2024-02-18

When you create a POI, the pointer is always at first located in the POI name field (see video).

https://github.com/osmandapp/OsmAnd/assets/116079541/a719b6b1-384d-4cf0-91d0-eb579864b3a8

But not all POIs require their name specified. If a user adds a poi without a name, one more click needed to leave the name field and go to a POI type field. Inexperienced users may consider POI name field as essential and fill it in. It should be noted that the poi type must always be specified.

It is proposed to swap the poi name and type fields so that the pointer is initially located in the POI type field.

vshcherb commented 5 months ago

We could have a special list and different UI for POI that are not supposed to have names

Nine-Tailed commented 3 weeks ago

To start, just change the order of the first two lines so that the user first selects the POI type, then enters the name if there is one.