search

osmandapp / OsmAnd

OsmAnd
https://osmand.net
Other
4.62k stars 1.01k forks source link

OSM 'Fixme' objects still visible on the map after disabling the OSM Editing plugin #18736

Open Max1234-Ita opened 9 months ago

Max1234-Ita commented 9 months ago

Description

After I enable the OpenStreetMap Editing plugin, I can see several options in the Configure map menu, allowing tho show/hide several features like OSM notes and FIXME objects; however, when the plugin is disabled, the FIXME label remain on the map and there's no way to make them disappear except from re-enabling the plugin again and manually removing them from the Configure map.

Steps to reproduce

  1. Launch OsmAnd;
  2. Go to menu /// -> Configure map; Verify the the OSM editing options are NOT present in the menu;
  3. Go to /// -> Plugins -> OpenStreetMap Editing ==> Enable the plugin; optionally, perform login to an OSM account;
  4. Go to menu /// -> Configure map; Verify that the OSM editing options are present in the menu (OSM notes (online), OSM edits, Fixme tags);
  5. Set the OSM Notes and Fixme tags option to 'on';
  6. Verify that the objects corresponding to the enabled categories are visible on the map
  7. Keeping at least one fixme tag visible on the map, go back to the menu /// -> Plugins -> OpenStreetMap Editing and turn it off;
  8. On the map, verify that the FIXME labels are still visible
  9. Verify that, in the menu /// -> Configure map, the options in the OpenStreetMap menu are not visible anymore (correct behaviour)

Video link: https://youtu.be/WgP1jy6pnHQ

Actual result

The Fixme labels are still visible on the map after the OSM Editing plugin has been disabled; The Configure map menu doesn't show anymore the options allowing to remove them.

The only workaround available is re-enabling the plugin, manually turn off the Fixme tags option and disabling the plugin again.

(see attached video link)

Expected result

Once the OSM editing plugin has been disabled, the FIXME object highlightings and the related labels should disappear as well.

Your Environment (required)

WARNING Crash-Logs MAY contain information you deem sensitive. Review this CAREFULLY before posting your issue!

OsmAnd Version: Observed on OsmAnd 4.5.10 and  OsmAnd Nightly 4.6.0
Android/iOS version: Android 11 (v. 4.5.10); Android 14 (v. 4.5.10 and v.4.6.0)
Device model: Samsung Galaxy A50 (SM-A505 FN) with Android 10; Google Pixel tablet (emulated in Android Studio) with Android 14.
Crash-Logs: None
zipav commented 9 months ago

OsmAnd Nightly 4.7.0#1240m, released: 2023-12-19

https://github.com/osmandapp/OsmAnd/assets/123936521/cb28dc79-9681-4d61-8e2b-d72b78226c49